Re: [PATCH v4 02/10] scsi: core: Change the return type of .eh_timed_out()

Mike Christie
2022-10-20T17:23:37Z

On 10/18/22 3:29 PM, Bart Van Assche wrote:
> Commit 6600593cbd93 ("block: rename BLK_EH_NOT_HANDLED to BLK_EH_DONE")
> made it impossible for .eh_timed_out() implementations to call
> scsi_done() without causing a crash. Restore support for SCSI timeout
> handlers to call scsi_done() as follows:
> * Change all .eh_timed_out() handlers as follows:
> - Change the return type into enum scsi_timeout_action.
> - Change BLK_EH_RESET_TIMER into SCSI_EH_RESET_TIMER.
> - Change BLK_EH_DONE into SCSI_EH_NOT_HANDLED.
> * In scsi_timeout(), convert the SCSI_EH_* values into BLK_EH_* values.

Reviewed-by: Mike Christie <michael.christie@oracle.com>