From: Markus Elfring <Markus.Elfring@web.de>
To: Alex Dewar <alex.dewar@gmx.co.uk>, linux-scsi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Hannes Reinecke <hare@suse.com>,
"James E. J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Qiujun Huang <hqjagain@gmail.com>
Subject: Re: scsi: aic7xxx: Remove null pointer checks before kfree()
Date: Thu, 9 Apr 2020 16:27:04 +0200 [thread overview]
Message-ID: <cd462354-a14c-ddb2-c728-17a6073a5de0@web.de> (raw)
In-Reply-To: <20200409114813.g3k4phoguduz6pw2@medion>
> The thing is that this seems like an obvious improvement
Such a view can be promising.
> (albeit not a terribly critical one).
The prioritisation influences change integration considerably.
> It reduces SLoC and removes an unnecessary check.
I hope that such goals will be reconsidered also for this software module.
> AFAICS the patch you mention wasn't rejected on technical grounds,
> but simply wasn't picked up.
The usual factors were involved for free software development.
> If there is a reason why this change isn't warranted
> then I'd like to know why so I can send better patches in future :-)
I hope that also your change interests can increase chances for
software evolution in desired directions.
With which delays will specific improvements be achieved?
Regards,
Markus
prev parent reply other threads:[~2020-04-09 14:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-05 20:02 [PATCH] scsi: aic7xxx: Remove null pointer checks before kfree() Markus Elfring
2020-04-06 1:14 ` Qiujun Huang
2020-04-07 15:54 ` Alex Dewar
2020-04-07 16:32 ` Markus Elfring
2020-04-09 11:48 ` Alex Dewar
2020-04-09 14:27 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd462354-a14c-ddb2-c728-17a6073a5de0@web.de \
--to=markus.elfring@web.de \
--cc=alex.dewar@gmx.co.uk \
--cc=hare@suse.com \
--cc=hqjagain@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox