RE: [PATCH v3 11/24] mpi3mr: print ioc info for debugging

[Kashyap Desai <kashyap.desai@broadcom.com>]

[-- Attachment #1: Type: text/plain, Size: 2090 bytes --]

> > +
> > +	for (i = 0; i < ARRAY_SIZE(mpi3mr_protocols); i++) {
> > +		if (mrioc->facts.protocol_flags &
> > +		    mpi3mr_protocols[i].protocol) {
> > +			if (is_string_nonempty)
> > +				strcat(protocol, ",");
> > +			strcat(protocol, mpi3mr_protocols[i].name);
> > +			is_string_nonempty = true;
>
> Please check for string overflows here.

Hannes - This is fixed in V4. Please review V4. Planning to post V4 today.

>
> > +		}
> > +	}
> > +
> > +	is_string_nonempty = false;
> > +	for (i = 0; i < ARRAY_SIZE(mpi3mr_capabilities); i++) {
> > +		if (mrioc->facts.protocol_flags &
> > +		    mpi3mr_capabilities[i].capability) {
> > +			if (is_string_nonempty)
> > +				strcat(capabilities, ",");
> > +			strcat(capabilities, mpi3mr_capabilities[i].name);
> > +			is_string_nonempty = true;
>
> Same here.
>
> > +		}
> > +	}
> > +
> > +	ioc_info(mrioc, "Protocol=(%s), Capabilities=(%s)\n",
> > +	    protocol, capabilities);
> > +}
> >
> >  /**
> >   * mpi3mr_cleanup_resources - Free PCI resources @@ -2808,6 +2887,7
> > @@ int mpi3mr_init_ioc(struct mpi3mr_ioc *mrioc, u8 re_init)
> >  		}
> >
> >  	}
> > +	mpi3mr_print_ioc_info(mrioc);
> >
> >  	retval = mpi3mr_alloc_reply_sense_bufs(mrioc);
> >  	if (retval) {
> > diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c
> > b/drivers/scsi/mpi3mr/mpi3mr_os.c index d82581ec73e1..39928e2997ba
> > 100644
> > --- a/drivers/scsi/mpi3mr/mpi3mr_os.c
> > +++ b/drivers/scsi/mpi3mr/mpi3mr_os.c
> > @@ -339,6 +339,7 @@ void mpi3mr_invalidate_devhandles(struct
> mpi3mr_ioc *mrioc)
> >   * mpi3mr_flush_scmd - Flush individual SCSI command
> >   * @rq: Block request
> >   * @data: Adapter instance reference
> > + * @reserved: N/A. Currently not used
> >   *
> >   * Return the SCSI command to the upper layers if it is in LLD
> >   * scope.
> >
> Cheers,
>
> Hannes
> --
> Dr. Hannes Reinecke		        Kernel Storage Architect
> hare@suse.de			               +49 911 74053 688
> SUSE Software Solutions Germany GmbH, 90409 Nürnberg
> GF: F. Imendörffer, HRB 36809 (AG Nürnberg)

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]