From: Damien Le Moal <dlemoal@kernel.org>
To: Bart Van Assche <bvanassche@acm.org>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>, Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH v9 03/17] block/mq-deadline: Only use zone locking if necessary
Date: Thu, 17 Aug 2023 20:02:16 +0900 [thread overview]
Message-ID: <ce13331c-3cc6-32bb-b154-70621be52b21@kernel.org> (raw)
In-Reply-To: <20230816195447.3703954-4-bvanassche@acm.org>
On 8/17/23 04:53, Bart Van Assche wrote:
> Measurements have shown that limiting the queue depth to one per zone for
> zoned writes has a significant negative performance impact on zoned UFS
> devices. Hence this patch that disables zone locking by the mq-deadline
> scheduler if the storage controller preserves the command order. This
> patch is based on the following assumptions:
> - It happens infrequently that zoned write requests are reordered by the
> block layer.
> - The I/O priority of all write requests is the same per zone.
> - Either no I/O scheduler is used or an I/O scheduler is used that
> serializes write requests per zone.
>
> Cc: Damien Le Moal <dlemoal@kernel.org>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Ming Lei <ming.lei@redhat.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Looks OK to me.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2023-08-17 11:03 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 19:53 [PATCH v9 00/17] Improve performance for zoned UFS devices Bart Van Assche
2023-08-16 19:53 ` [PATCH v9 01/17] block: Introduce more member variables related to zone write locking Bart Van Assche
2023-08-17 11:00 ` Damien Le Moal
2023-08-16 19:53 ` [PATCH v9 02/17] block: Only use write locking if necessary Bart Van Assche
2023-08-17 11:01 ` Damien Le Moal
2023-08-17 14:21 ` Bart Van Assche
2023-08-16 19:53 ` [PATCH v9 03/17] block/mq-deadline: Only use zone " Bart Van Assche
2023-08-17 11:02 ` Damien Le Moal [this message]
2023-08-16 19:53 ` [PATCH v9 04/17] scsi: core: Call .eh_prepare_resubmit() before resubmitting Bart Van Assche
2023-08-17 11:10 ` Damien Le Moal
2023-08-17 14:26 ` Bart Van Assche
2023-08-18 2:38 ` Damien Le Moal
2023-08-16 19:53 ` [PATCH v9 05/17] scsi: core: Add unit tests for scsi_call_prepare_resubmit() Bart Van Assche
2023-08-16 19:53 ` [PATCH v9 06/17] scsi: sd: Sort commands by LBA before resubmitting Bart Van Assche
2023-08-17 11:13 ` Damien Le Moal
2023-08-17 14:34 ` Bart Van Assche
2023-08-18 2:41 ` Damien Le Moal
2023-08-16 19:53 ` [PATCH v9 07/17] scsi: core: Retry unaligned zoned writes Bart Van Assche
2023-08-17 11:21 ` Damien Le Moal
2023-08-16 19:53 ` [PATCH v9 08/17] scsi: sd_zbc: Only require an I/O scheduler if needed Bart Van Assche
2023-08-17 11:21 ` Damien Le Moal
2023-08-16 19:53 ` [PATCH v9 09/17] scsi: scsi_debug: Support disabling zone write locking Bart Van Assche
2023-08-17 11:25 ` Damien Le Moal
2023-08-17 14:35 ` Bart Van Assche
2023-08-16 19:53 ` [PATCH v9 10/17] scsi: scsi_debug: Support injecting unaligned write errors Bart Van Assche
2023-08-17 11:29 ` Damien Le Moal
2023-08-16 19:53 ` [PATCH v9 11/17] scsi: ufs: hisi: Rework the code that disables auto-hibernation Bart Van Assche
2023-08-16 19:53 ` [PATCH v9 12/17] scsi: ufs: mediatek: Rework the code for disabling auto-hibernation Bart Van Assche
2023-08-17 18:40 ` Bao D. Nguyen
2023-08-17 19:13 ` Bart Van Assche
2023-08-16 19:53 ` [PATCH v9 13/17] scsi: ufs: sprd: " Bart Van Assche
2023-08-16 19:53 ` [PATCH v9 14/17] scsi: ufs: Rename ufshcd_auto_hibern8_enable() and make it static Bart Van Assche
2023-08-17 18:49 ` Bao D. Nguyen
2023-08-17 19:16 ` Bart Van Assche
2023-08-17 21:48 ` Bao D. Nguyen
2023-08-16 19:53 ` [PATCH v9 15/17] scsi: ufs: Simplify ufshcd_auto_hibern8_update() Bart Van Assche
2023-08-16 19:53 ` [PATCH v9 16/17] scsi: ufs: Forbid auto-hibernation without I/O scheduler Bart Van Assche
2023-08-17 18:50 ` Bao D. Nguyen
2023-08-17 19:18 ` Bart Van Assche
2023-08-16 19:53 ` [PATCH v9 17/17] scsi: ufs: Inform the block layer about write ordering Bart Van Assche
2023-08-17 19:00 ` Bao D. Nguyen
2023-08-17 19:34 ` Bart Van Assche
2023-08-17 21:47 ` Bao D. Nguyen
2023-08-17 22:05 ` Bart Van Assche
2023-08-18 0:19 ` Bao D. Nguyen
2023-08-18 17:56 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce13331c-3cc6-32bb-b154-70621be52b21@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox