[PATCH -next] scsi: ufs: fix error return code in ufshcd_init()

[PATCH -next] scsi: ufs: fix error return code in ufshcd_init()

[Wei Yongjun]

From: Wei Yongjun <weiyongjun1@huawei.com>

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/scsi/ufs/ufshcd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 37f3c51..6aebb7e 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -6500,6 +6500,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq)
 		if (IS_ERR(hba->devfreq)) {
 			dev_err(hba->dev, "Unable to register with devfreq %ld\n",
 					PTR_ERR(hba->devfreq));
+			err = PTR_ERR(hba->devfreq);
 			goto out_remove_scsi_host;
 		}
 		/* Suspend devfreq until the UFS device is detected */

Re: [PATCH -next] scsi: ufs: fix error return code in ufshcd_init()

[subhashj]

Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>

On 2016-09-28 07:49, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/scsi/ufs/ufshcd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 37f3c51..6aebb7e 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -6500,6 +6500,7 @@ int ufshcd_init(struct ufs_hba *hba, void
> __iomem *mmio_base, unsigned int irq)
>  		if (IS_ERR(hba->devfreq)) {
>  			dev_err(hba->dev, "Unable to register with devfreq %ld\n",
>  					PTR_ERR(hba->devfreq));
> +			err = PTR_ERR(hba->devfreq);
>  			goto out_remove_scsi_host;
>  		}
>  		/* Suspend devfreq until the UFS device is detected */
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" 
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH -next] scsi: ufs: fix error return code in ufshcd_init()

[Kiwoong Kim]

Reviewed-by: Kiwoong Kim <kwmad.kim@samsung.com>

> -----Original Message-----
> From: linux-scsi-owner@vger.kernel.org [mailto:linux-scsi-
> owner@vger.kernel.org] On Behalf Of subhashj@codeaurora.org
> Sent: Thursday, September 29, 2016 7:50 AM
> To: Wei Yongjun
> Cc: Vinayak Holikatti; James E.J. Bottomley; Martin K. Petersen; Wei
> Yongjun; linux-scsi@vger.kernel.org; linux-scsi-owner@vger.kernel.org
> Subject: Re: [PATCH -next] scsi: ufs: fix error return code in
> ufshcd_init()
> 
> Looks good to me.
> Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
> 
> On 2016-09-28 07:49, Wei Yongjun wrote:
> > From: Wei Yongjun <weiyongjun1@huawei.com>
> >
> > Fix to return a negative error code from the error handling case
> > instead of 0, as done elsewhere in this function.
> >
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> > ---
> >  drivers/scsi/ufs/ufshcd.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> > index 37f3c51..6aebb7e 100644
> > --- a/drivers/scsi/ufs/ufshcd.c
> > +++ b/drivers/scsi/ufs/ufshcd.c
> > @@ -6500,6 +6500,7 @@ int ufshcd_init(struct ufs_hba *hba, void
> > __iomem *mmio_base, unsigned int irq)
> >  		if (IS_ERR(hba->devfreq)) {
> >  			dev_err(hba->dev, "Unable to register with
> devfreq %ld\n",
> >  					PTR_ERR(hba->devfreq));
> > +			err = PTR_ERR(hba->devfreq);
> >  			goto out_remove_scsi_host;
> >  		}
> >  		/* Suspend devfreq until the UFS device is detected */
> >
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-scsi"
> > in
> > the body of a message to majordomo@vger.kernel.org More majordomo info
> > at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html

Re: [PATCH -next] scsi: ufs: fix error return code in ufshcd_init()

[Martin K. Petersen]

>>>>> "Wei" == Wei Yongjun <weiyj.lk@gmail.com> writes:

Wei> Fix to return a negative error code from the error handling case
Wei> instead of 0, as done elsewhere in this function.

Applied to 4.9/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering