From: Bart Van Assche <bvanassche@acm.org>
To: Maurizio Lombardi <mlombard@redhat.com>, martin.petersen@oracle.com
Cc: michael.christie@oracle.com, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, mlombard@bsdbackstore.eu,
d.bogdanov@yadro.com
Subject: Re: [PATCH V2] target: generate correct string identifiers for PR OUT transport IDs
Date: Mon, 7 Jul 2025 10:28:39 -0700 [thread overview]
Message-ID: <ceabaefd-6df5-4d08-9b6c-6ce75611ebef@acm.org> (raw)
In-Reply-To: <20250703081224.115865-1-mlombard@redhat.com>
On 7/3/25 1:12 AM, Maurizio Lombardi wrote:
> -static char *iscsi_parse_pr_out_transport_id(
> +static void sas_parse_pr_out_transport_id(char *buf, char *i_str)
> +{
> + char hex[17] = {0};
Isn't "{}" the preferred way to zero-initialize arrays and data
structures? "{}" has the advantage over "{0}" that it doesn't trigger
any compiler warnings when initializing a data structure in which the
first member is a pointer.
Thanks,
Bart.
next prev parent reply other threads:[~2025-07-07 17:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 8:12 [PATCH V2] target: generate correct string identifiers for PR OUT transport IDs Maurizio Lombardi
2025-07-07 9:22 ` Dmitry Bogdanov
2025-07-07 17:28 ` Bart Van Assche [this message]
2025-07-09 16:57 ` Maurizio Lombardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceabaefd-6df5-4d08-9b6c-6ce75611ebef@acm.org \
--to=bvanassche@acm.org \
--cc=d.bogdanov@yadro.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=mlombard@bsdbackstore.eu \
--cc=mlombard@redhat.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).