From: Bean Huo <huobean@gmail.com>
To: Ziqi Chen <quic_ziqichen@quicinc.com>,
quic_cang@quicinc.com, bvanassche@acm.org, mani@kernel.org,
beanhuo@micron.com, avri.altman@wdc.com,
junwoo80.lee@samsung.com, martin.petersen@oracle.com,
quic_nguyenb@quicinc.com, quic_nitirawa@quicinc.com,
quic_rampraka@quicinc.com
Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
Alim Akhtar <alim.akhtar@samsung.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Peter Wang <peter.wang@mediatek.com>,
Stanley Jhu <chu.stanley@gmail.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Andrew Halaney <ahalaney@redhat.com>,
Eric Biggers <ebiggers@google.com>,
Minwoo Im <minwoo.im@samsung.com>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:UNIVERSAL FLASH STORAGE HOST CONTROLLER
DRIVER..." <linux-mediatek@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support:Keyword:mediatek"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 1/8] scsi: ufs: core: Pass target_freq to clk_scale_notify() vop
Date: Mon, 03 Feb 2025 10:37:56 +0100 [thread overview]
Message-ID: <ceeee4f93b22ab53c4243eec85449a95b0305c70.camel@gmail.com> (raw)
In-Reply-To: <20250203081109.1614395-2-quic_ziqichen@quicinc.com>
On Mon, 2025-02-03 at 16:11 +0800, Ziqi Chen wrote:
> From: Can Guo <quic_cang@quicinc.com>
>
> Instead of only two frequencies, if OPP V2 is used, the UFS devfreq
> clock
> scaling may scale the clock among multiple frequencies, so just
> passing
> up/down to vop clk_scale_notify() is not enough to cover the
> intermediate
> clock freqs between the min and max freqs. Hence pass the target_freq
> ,
> which will be used in successive commits, to clk_scale_notify() to
> allow
> the vop to perform corresponding configurations with regard to the
> clock
> freqs.
>
> Signed-off-by: Can Guo <quic_cang@quicinc.com>
> Co-developed-by: Ziqi Chen <quic_ziqichen@quicinc.com>
> Signed-off-by: Ziqi Chen <quic_ziqichen@quicinc.com>
I have reviewed patches [1/8], [2/8], [3/8], [4/8] in the v2, since you
just changed coding types, and typos , but no logic change in v3. Add
my review tag agaion:
Reviewed-by: Bean Huo <beanhuo@micron.com>
next prev parent reply other threads:[~2025-02-03 9:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 8:11 [PATCH v3 0/8] Support Multi-frequency scale for UFS Ziqi Chen
2025-02-03 8:11 ` [PATCH v3 1/8] scsi: ufs: core: Pass target_freq to clk_scale_notify() vop Ziqi Chen
2025-02-03 9:37 ` Bean Huo [this message]
2025-02-06 7:32 ` Ziqi Chen
2025-02-05 18:02 ` Bart Van Assche
2025-02-03 8:11 ` [PATCH v3 2/8] scsi: ufs: qcom: Pass target_freq to clk scale pre and post change Ziqi Chen
2025-02-03 10:09 ` Bean Huo
2025-02-03 8:11 ` [PATCH v3 3/8] scsi: ufs: core: Add a vop to map clock frequency to gear speed Ziqi Chen
2025-02-03 12:55 ` Bean Huo
2025-02-06 7:47 ` Ziqi Chen
2025-02-05 18:03 ` Bart Van Assche
2025-02-03 8:11 ` [PATCH v3 4/8] scsi: ufs: qcom: Implement the freq_to_gear_speed() vop Ziqi Chen
2025-02-03 13:22 ` Bean Huo
2025-02-03 8:11 ` [PATCH v3 5/8] scsi: ufs: core: Enable multi-level gear scaling Ziqi Chen
2025-02-05 18:04 ` Bart Van Assche
2025-02-05 20:01 ` Bean Huo
2025-02-06 7:56 ` Ziqi Chen
2025-02-03 8:11 ` [PATCH v3 6/8] scsi: ufs: core: Check if scaling up is required when disable clkscale Ziqi Chen
2025-02-05 18:05 ` Bart Van Assche
2025-02-03 8:11 ` [PATCH v3 7/8] scsi: ufs: core: Toggle Write Booster during clock scaling base on gear speed Ziqi Chen
2025-02-05 18:09 ` Bart Van Assche
2025-02-06 7:53 ` Ziqi Chen
2025-02-05 20:03 ` Bean Huo
2025-02-06 7:57 ` Ziqi Chen
2025-02-03 8:11 ` [PATCH v3 8/8] ABI: sysfs-driver-ufs: Add missing UFS sysfs attributes Ziqi Chen
2025-02-05 18:12 ` Bart Van Assche
2025-02-06 7:54 ` Ziqi Chen
2025-02-06 9:53 ` [PATCH v3 0/8] Support Multi-frequency scale for UFS neil.armstrong
2025-02-07 3:29 ` Ziqi Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceeee4f93b22ab53c4243eec85449a95b0305c70.camel@gmail.com \
--to=huobean@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=ahalaney@redhat.com \
--cc=alim.akhtar@samsung.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=chu.stanley@gmail.com \
--cc=ebiggers@google.com \
--cc=junwoo80.lee@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=minwoo.im@samsung.com \
--cc=peter.wang@mediatek.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_rampraka@quicinc.com \
--cc=quic_ziqichen@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox