From: Joe Perches <joe@perches.com>
To: MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org
Cc: Sathya Prakash <sathya.prakash@broadcom.com>,
Chaitra P B <chaitra.basappa@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/7] Neaten logging uses
Date: Mon, 17 Sep 2018 08:01:07 -0700 [thread overview]
Message-ID: <cover.1537183087.git.joe@perches.com> (raw)
Several defects exist in the logging uses
o Missing KERN_<LEVEL>
o Unnecessary KERN_<LEVEL> uses with panic
o Mismatched MPT3SAS_FMT and %s: with name and __func__
Correct these defects and perhaps add some clarity to the logging.
Joe Perches (7):
mpt3sas: Add ioc_<level> logging macros
mpt3sas: Convert uses of pr_<level> with MPT3SAS_FMT to ioc_<level>
mpt3sas: Convert mlsleading uses of pr_<level> with MPT3SAS_FMT
mpt3sas: Convert logging uses with MPT3SAS_FMT and reply_q_name to %s:
mpt3sas: Remove KERN_WARNING from panic uses
mpt3sas: Convert logging uses with MPT3SAS_FMT without logging levels
mpt3sas: Remove unused macro MPT3SAS_FMT
drivers/scsi/mpt3sas/mpt3sas_base.c | 1116 +++++++++-----------
drivers/scsi/mpt3sas/mpt3sas_base.h | 9 +-
drivers/scsi/mpt3sas/mpt3sas_config.c | 89 +-
drivers/scsi/mpt3sas/mpt3sas_ctl.c | 493 ++++-----
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 1487 ++++++++++++---------------
drivers/scsi/mpt3sas/mpt3sas_transport.c | 337 +++---
drivers/scsi/mpt3sas/mpt3sas_trigger_diag.c | 101 +-
drivers/scsi/mpt3sas/mpt3sas_warpdrive.c | 70 +-
8 files changed, 1618 insertions(+), 2084 deletions(-)
--
2.15.0
next reply other threads:[~2018-09-17 15:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 15:01 Joe Perches [this message]
2018-09-17 15:01 ` [PATCH 1/7] mpt3sas: Add ioc_<level> logging macros Joe Perches
2018-10-04 10:25 ` Suganath Prabu Subramani
2018-09-17 15:01 ` [PATCH 2/7] mpt3sas: Convert uses of pr_<level> with MPT3SAS_FMT to ioc_<level> Joe Perches
2018-10-04 10:28 ` Suganath Prabu Subramani
2018-09-17 15:01 ` [PATCH 3/7] mpt3sas: Convert mlsleading uses of pr_<level> with MPT3SAS_FMT Joe Perches
2018-10-04 10:28 ` Suganath Prabu Subramani
2018-09-17 15:01 ` [PATCH 4/7] mpt3sas: Convert logging uses with MPT3SAS_FMT and reply_q_name to %s: Joe Perches
2018-10-04 10:29 ` Suganath Prabu Subramani
2018-09-17 15:01 ` [PATCH 5/7] mpt3sas: Remove KERN_WARNING from panic uses Joe Perches
2018-10-04 10:29 ` Suganath Prabu Subramani
2018-09-17 15:01 ` [PATCH 6/7] mpt3sas: Convert logging uses with MPT3SAS_FMT without logging levels Joe Perches
2018-10-04 10:30 ` Suganath Prabu Subramani
2018-09-17 15:01 ` [PATCH 7/7] mpt3sas: Remove unused macro MPT3SAS_FMT Joe Perches
2018-10-04 10:30 ` Suganath Prabu Subramani
2018-10-01 23:46 ` [PATCH 0/7] Neaten logging uses Joe Perches
2018-10-11 1:54 ` Martin K. Petersen
2018-10-11 15:37 ` Joe Perches
2018-10-11 23:25 ` Martin K. Petersen
2018-10-12 0:01 ` Joe Perches
2018-10-12 0:41 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1537183087.git.joe@perches.com \
--to=joe@perches.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=chaitra.basappa@broadcom.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sathya.prakash@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).