From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03F8DC77B7A for ; Mon, 29 May 2023 14:04:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230215AbjE2OEl (ORCPT ); Mon, 29 May 2023 10:04:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230260AbjE2OEe (ORCPT ); Mon, 29 May 2023 10:04:34 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80FD91A5 for ; Mon, 29 May 2023 07:03:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685368949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zJ8lVkJGMAf7X6sgK7+SzlistNxfN3tza5OmhJom+fY=; b=Y1d51SjuWUwuzEjZ5mG/0xDJfZbbB6AN4cds61E9HDAYALyZ/mt+NEQEWHj7Cuxcoau345 1fHnH+FbANsrN9stLgCXPNftY2be5uIuD/lq3/rJTiOBI/sNv+YzqpUpOQlxtTc0t9/vWa 6cXTSP9FfHjG9nSQer0mXTjIYYKQ1uI= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-527-7Q8vHxBRMhq7A5XYRloTcQ-1; Mon, 29 May 2023 10:02:28 -0400 X-MC-Unique: 7Q8vHxBRMhq7A5XYRloTcQ-1 Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-50de84a3861so2755401a12.3 for ; Mon, 29 May 2023 07:02:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685368947; x=1687960947; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zJ8lVkJGMAf7X6sgK7+SzlistNxfN3tza5OmhJom+fY=; b=BPp37OzG45TP9cmJWgmFEkYsnFfD+pTu2SG/eLRzReblcXgD/WW0q5E6m562S9HJlz 3kfEIszPQdaJHTwLg5ECT7p1DsUXA1pa8VTjZUMcOzJngNEcEy58o5zwAhTxa7bz8lGK N5BXKMBQ2/7w8YDpz827DI54yRKLWud4TN7fgbQadoS3mqZeFUEL0QnDxBoFv1etV8B5 qdsLrj8t67gduVqsAh88Q0eDgcY4A0a5Mr4ZVCYwrC9mhRWbs86dX1gRE4MXVgxXHoV6 YVElgxY5+kFaoCobnfrn8/ZAJDgacTXyY6jfBkjDpApLeX+P7igMuhV97/1vqXB8Md0j sjzQ== X-Gm-Message-State: AC+VfDzsMc/ig8I7SZc8zJiD9MBWx93ipr+J+pP7ieU6KCajL2EBw3ur LgTKM3IVxCFqNc5WFIVaakWe3AvWcuBPWW/L+h2TMRI9o3B2PGGkqAcrvaamG0YWd0qA4ujplB2 wlCquXfGgaEqs3zTztTm8JA== X-Received: by 2002:aa7:ccd8:0:b0:514:a179:b151 with SMTP id y24-20020aa7ccd8000000b00514a179b151mr1610793edt.41.1685368947364; Mon, 29 May 2023 07:02:27 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ510QWjG+RFlHmeCrPdvlqvEtFovcewTXQ5zlrjDXHvEmH5MVjEwz12mTI4MyNmn0RyD1YbTg== X-Received: by 2002:aa7:ccd8:0:b0:514:a179:b151 with SMTP id y24-20020aa7ccd8000000b00514a179b151mr1610778edt.41.1685368947089; Mon, 29 May 2023 07:02:27 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id ay1-20020a056402202100b005066cadcc54sm3115204edb.43.2023.05.29.07.02.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 May 2023 07:02:26 -0700 (PDT) Message-ID: Date: Mon, 29 May 2023 16:02:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] scsi: virtio_scsi: Remove a useless function call Content-Language: en-US To: Christophe JAILLET , "Michael S. Tsirkin" , Jason Wang , Stefan Hajnoczi , "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-scsi@vger.kernel.org References: <08740635cdb0f8293e57c557b22e048daae50961.1685345683.git.christophe.jaillet@wanadoo.fr> From: Paolo Bonzini In-Reply-To: <08740635cdb0f8293e57c557b22e048daae50961.1685345683.git.christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 5/29/23 09:35, Christophe JAILLET wrote: > 'inq_result' is known to be NULL. There is no point calling kfree(). > > Signed-off-by: Christophe JAILLET > --- > drivers/scsi/virtio_scsi.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c > index 58498da9869a..bd5633667d01 100644 > --- a/drivers/scsi/virtio_scsi.c > +++ b/drivers/scsi/virtio_scsi.c > @@ -338,10 +338,8 @@ static int virtscsi_rescan_hotunplug(struct virtio_scsi *vscsi) > int result, inquiry_len, inq_result_len = 256; > char *inq_result = kmalloc(inq_result_len, GFP_KERNEL); > > - if (!inq_result) { > - kfree(inq_result); > + if (!inq_result) > return -ENOMEM; > - } > > shost_for_each_device(sdev, shost) { > inquiry_len = sdev->inquiry_len ? sdev->inquiry_len : 36; Reviewed-by: Paolo Bonzini