From: Bart Van Assche <bvanassche@acm.org>
To: John Garry <john.g.garry@oracle.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH v6 07/28] scsi_debug: Abort SCSI commands via an internal command
Date: Thu, 23 Oct 2025 09:19:46 -0700 [thread overview]
Message-ID: <d15d527d-1cd4-4fb4-9b98-0bae9a723f23@acm.org> (raw)
In-Reply-To: <0507fd03-b3b0-436e-9f5f-72f7a02484bb@oracle.com>
On 10/22/25 1:46 AM, John Garry wrote:
> Apart from some small comments,
>
> Reviewed-by: John Garry <john.g.garry@oracle.com>
Thanks!
>> + scoped_guard(spinlock_irqsave, &to_be_aborted_sdsc->lock)
>> + res = scsi_debug_stop_cmnd(to_be_aborted_scmd);
>> + if (res)
>> + pr_info("%s: aborted command with tag %#x\n",
>
> I think that it is better to print in decimal
>
> Or, if using hex, use 0x prefix
%#x causes printk() to emit a "0x" prefix. See also the SPECIAL flag and
the spec_flag() function in lib/vsnprintf.c. Anyway, I will change the
output format to decimal.
Bart.
next prev parent reply other threads:[~2025-10-23 16:19 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 20:15 [PATCH v6 00/28] Optimize the hot path in the UFS driver Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 01/28] scsi: core: Support allocating reserved commands Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 02/28] scsi: core: Move two statements Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 03/28] scsi: core: Make the budget map optional Bart Van Assche
2025-10-16 6:06 ` Hannes Reinecke
2025-10-22 8:29 ` John Garry
2025-10-22 17:23 ` Bart Van Assche
2025-10-23 10:02 ` John Garry
2025-10-14 20:15 ` [PATCH v6 04/28] scsi: core: Support allocating a pseudo SCSI device Bart Van Assche
2025-10-20 11:10 ` John Garry
2025-10-20 16:10 ` Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 05/28] scsi: core: Introduce .queue_reserved_command() Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 06/28] scsi: core: Add scsi_{get,put}_internal_cmd() helpers Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 07/28] scsi_debug: Abort SCSI commands via an internal command Bart Van Assche
2025-10-22 8:46 ` John Garry
2025-10-23 16:19 ` Bart Van Assche [this message]
2025-10-14 20:15 ` [PATCH v6 08/28] ufs: core: Move an assignment in ufshcd_mcq_process_cqe() Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 09/28] ufs: core: Change the type of one ufshcd_add_cmd_upiu_trace() argument Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 10/28] ufs: core: Only call ufshcd_add_command_trace() for SCSI commands Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 11/28] ufs: core: Change the type of one ufshcd_add_command_trace() argument Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 12/28] ufs: core: Change the type of one ufshcd_send_command() argument Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 13/28] ufs: core: Only call ufshcd_should_inform_monitor() for SCSI commands Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 14/28] ufs: core: Change the monitor function argument types Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 15/28] ufs: core: Rework ufshcd_mcq_compl_pending_transfer() Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 16/28] ufs: core: Rework ufshcd_eh_device_reset_handler() Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 17/28] ufs: core: Rework the SCSI host queue depth calculation code Bart Van Assche
2025-10-14 20:16 ` [PATCH v6 18/28] ufs: core: Allocate the SCSI host earlier Bart Van Assche
2025-10-14 20:16 ` [PATCH v6 19/28] ufs: core: Call ufshcd_init_lrb() later Bart Van Assche
2025-10-14 20:16 ` [PATCH v6 20/28] ufs: core: Use hba->reserved_slot Bart Van Assche
2025-10-14 20:16 ` [PATCH v6 21/28] ufs: core: Make the reserved slot a reserved request Bart Van Assche
2025-10-14 20:16 ` [PATCH v6 22/28] ufs: core: Do not clear driver-private command data Bart Van Assche
2025-10-14 20:16 ` [PATCH v6 23/28] ufs: core: Optimize the hot path Bart Van Assche
2025-10-14 20:16 ` [PATCH v6 24/28] ufs: core: Pass a SCSI pointer instead of an LRB pointer Bart Van Assche
2025-10-14 20:16 ` [PATCH v6 25/28] ufs: core: Remove the ufshcd_lrb task_tag member Bart Van Assche
2025-10-14 20:16 ` [PATCH v6 26/28] ufs: core: Make blk_mq_tagset_busy_iter() skip reserved requests Bart Van Assche
2025-10-14 20:16 ` [PATCH v6 27/28] ufs: core: Move code out of ufshcd_wait_for_dev_cmd() Bart Van Assche
2025-10-14 20:16 ` [PATCH v6 28/28] ufs: core: Switch to scsi_get_internal_cmd() Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d15d527d-1cd4-4fb4-9b98-0bae9a723f23@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=john.g.garry@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).