public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Phong Tran <tranmanphong@gmail.com>,
	aacraid@microsemi.com, jejb@linux.ibm.com,
	martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	keescook@chromium.org
Subject: Re: [PATCH v2] scsi: aacraid: fix -Wcast-function-type
Date: Sat, 7 Mar 2020 18:23:37 -0800	[thread overview]
Message-ID: <d18e3d83-d1b5-5979-c2ec-235e4f5095a3@acm.org> (raw)
In-Reply-To: <20200308020143.9351-1-tranmanphong@gmail.com>

On 2020-03-07 18:01, Phong Tran wrote:
> correct usage prototype of callback scsi_cmnd.scsi_done()
> Report by: https://github.com/KSPP/linux/issues/20

This description is confusing. I think a better description would have
been "Make the aacraid driver -Wcast-function-type clean."

Anyway:

Reviewed-by: Bart van Assche <bvanassche@acm.org>





  reply	other threads:[~2020-03-08  2:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-07 13:21 [PATCH] scsi: aacraid: fix -Wcast-function-type Phong Tran
2020-03-07 16:35 ` Bart Van Assche
2020-03-08  2:08   ` Phong Tran
2020-03-08  2:01 ` [PATCH v2] " Phong Tran
2020-03-08  2:23   ` Bart Van Assche [this message]
2020-03-09  9:23   ` John Garry
2020-03-09 15:53     ` [PATCH v3] scsi: aacraid: cleanup warning cast-function-type Phong Tran
2020-03-09 16:17       ` Kees Cook
2020-03-11  2:36       ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d18e3d83-d1b5-5979-c2ec-235e4f5095a3@acm.org \
    --to=bvanassche@acm.org \
    --cc=aacraid@microsemi.com \
    --cc=jejb@linux.ibm.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=tranmanphong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox