From: Bart Van Assche <bvanassche@acm.org>
To: sashiko-reviews@lists.linux.dev
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH v3 6/7] scsi: scsi_debug: Improve lock context annotations
Date: Wed, 30 Sep 2026 06:16:32 -0700 [thread overview]
Message-ID: <d383363b-f2e6-49a0-9f50-719c0895bf64@acm.org> (raw)
In-Reply-To: <20260929233530.7CD061F000FF@smtp.kernel.org>
On 9/29/26 4:35 PM, sashiko-bot@kernel.org wrote:
>> static inline void
>> sdeb_meta_write_lock(struct sdeb_store_info *sip)
>> + __acquires(&sip->macc_meta_lck)
>> + __context_unsafe(/*conditional locking*/)
>> {
>> - if (sdebug_no_rwlock) {
>> - if (sip)
>> - __acquire(&sip->macc_meta_lck);
>> - else
>> - __acquire(&sdeb_fake_rw_lck);
>> - } else {
>> + if (!sdebug_no_rwlock) {
>> if (sip)
>> write_lock(&sip->macc_meta_lck);
>> else
>> write_lock(&sdeb_fake_rw_lck);
>
> [Severity: Low]
> Does this also omit tracking for the sdeb_fake_rw_lck when sip is NULL?
These Sashiko findings are expected and are an unavoidable side effect
of how locking has been implemented in the scsi_debug kernel driver.
Bart.
next prev parent reply other threads:[~2026-09-30 13:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 23:22 [PATCH v3 0/7] scsi_debug: Enable lock context analysis Bart Van Assche
2026-09-29 23:22 ` [PATCH v3 1/7] scsi: scsi_debug: Fix a locking bug in resp_write_same() Bart Van Assche
2026-09-29 23:22 ` [PATCH v3 2/7] scsi: scsi_debug: Split resp_write_same() Bart Van Assche
2026-09-29 23:22 ` [PATCH v3 3/7] scsi: scsi_debug: Split corrupt_lbas() Bart Van Assche
2026-09-29 23:23 ` [PATCH v3 4/7] scsi: scsi_debug: Split resp_read_dt0() Bart Van Assche
2026-09-29 23:23 ` [PATCH v3 5/7] scsi: scsi_debug: Split resp_write_dt0() Bart Van Assche
2026-09-29 23:23 ` [PATCH v3 6/7] scsi: scsi_debug: Improve lock context annotations Bart Van Assche
2026-09-29 23:35 ` sashiko-bot
2026-09-30 13:16 ` Bart Van Assche [this message]
2026-09-29 23:23 ` [PATCH v3 7/7] scsi: core: Enable lock context analysis for the scsi_debug driver Bart Van Assche
2026-10-03 14:24 ` [PATCH v3 0/7] scsi_debug: Enable lock context analysis Martin K. Petersen (Oracle)
2026-10-04 22:39 ` Bart Van Assche
2026-10-06 1:39 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d383363b-f2e6-49a0-9f50-719c0895bf64@acm.org \
--to=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox