From: Douglas Gilbert <dgilbert@interlog.com>
To: Wenchao Hao <haowenchao2@huawei.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, louhongxiang@huawei.com
Subject: Re: [PATCH v5 10/10] scsi: scsi_debug: Add param to control sdev's allow_restart
Date: Sun, 8 Oct 2023 19:17:08 -0400 [thread overview]
Message-ID: <d61e88d3-e1b7-44e0-ba9b-f633be0b5b30@interlog.com> (raw)
In-Reply-To: <20230922092906.2645265-11-haowenchao2@huawei.com>
On 2023-09-22 05:29, Wenchao Hao wrote:
> Add new module param "allow_restart" to control if setup
> scsi_device's allow_restart flag. This is used to test scsi
> command finished with sense_key 0x6, asc 0x4 and ascq 0x2
>
> Signed-off-by: Wenchao Hao <haowenchao2@huawei.com>
Hi,
Looked at this and verified that the allow_restart flag of scsi_debug
devices (disks ?) is usually 0 and when the scsi_debug module is
started with allow_restart=1 then the allow_restart flag does indeed
change to 1. For example:
# cat /sys/class/scsi_disk/1\:0\:0\:0/allow_restart
1
That ASC/ASCQ code means: "Logical unit not ready, initializing command
required" according to my library. Played around with sg_start but didn't
see any change in how it reacts. According to scsi_device.h that flag's
description is: "issue START_UNIT in error handler" which implies it
changes how the EH handler reacts.
Perhaps the 3 line patch description could say a little more about how
to use this new parameter...
Tested-by: Douglas Gilbert <dgilbert@interlog.com>
<snip>
next prev parent reply other threads:[~2023-10-08 23:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 9:28 [PATCH v5 00/10] scsi:scsi_debug: Add error injection for single device Wenchao Hao
2023-09-22 9:28 ` [PATCH v5 01/10] scsi: scsi_debug: create scsi_debug directory in the debugfs filesystem Wenchao Hao
2023-09-28 1:13 ` Douglas Gilbert
2023-09-28 1:38 ` Wenchao Hao
2023-09-22 9:28 ` [PATCH v5 02/10] scsi: scsi_debug: Add interface to manage single device's error inject Wenchao Hao
2023-09-22 9:28 ` [PATCH v5 03/10] scsi: scsi_debug: Define grammar to remove added error injection Wenchao Hao
2023-09-22 9:29 ` [PATCH v5 04/10] scsi: scsi_debug: timeout command if the error is injected Wenchao Hao
2023-09-22 9:29 ` [PATCH v5 05/10] scsi: scsi_debug: Return failed value " Wenchao Hao
2023-09-22 9:29 ` [PATCH v5 06/10] scsi: scsi_debug: set command's result and sense data " Wenchao Hao
2023-10-05 10:40 ` Dan Carpenter
2023-09-22 9:29 ` [PATCH v5 07/10] scsi: scsi_debug: Add new error injection abort failed Wenchao Hao
2023-10-06 16:06 ` Douglas Gilbert
2023-09-22 9:29 ` [PATCH v5 08/10] scsi: scsi_debug: Add new error injection reset lun failed Wenchao Hao
2023-10-06 21:04 ` Douglas Gilbert
2023-10-07 9:45 ` Wenchao Hao
2023-09-22 9:29 ` [PATCH v5 09/10] scsi: scsi_debug: Add debugfs interface to fail target reset Wenchao Hao
2023-10-08 23:14 ` Douglas Gilbert
2023-09-22 9:29 ` [PATCH v5 10/10] scsi: scsi_debug: Add param to control sdev's allow_restart Wenchao Hao
2023-10-08 23:17 ` Douglas Gilbert [this message]
2023-10-09 7:19 ` Wenchao Hao
2023-09-27 15:38 ` [PATCH v5 00/10] scsi:scsi_debug: Add error injection for single device Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d61e88d3-e1b7-44e0-ba9b-f633be0b5b30@interlog.com \
--to=dgilbert@interlog.com \
--cc=haowenchao2@huawei.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=louhongxiang@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=open-iscsi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox