From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mo4-p02-ob.smtp.rzone.de (mo4-p02-ob.smtp.rzone.de [85.215.255.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47AF2386546; Mon, 23 Mar 2026 09:11:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=85.215.255.82 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257069; cv=pass; b=ikGBn9y5mMWXH3Y+HDxr4ZARJ893tX4AWNQd0P3MXZ8BHRcHWNMvjzTfoZwb913r6cDesfQZ4Hv1QOmYMNHn0jLztDtpbjbLgUUXSDpsZVjRyl6WwUrAnmm1XNglBUnOm3qOzPBFgqqEeeapoTvZKILYWhdmYUGgc4JG+KKjunE= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257069; c=relaxed/simple; bh=suw9KHLI1LNKkl/PCLrf2qkeUAqtRJBNl4/N/e6MHDw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=hcKGZcWuy9nGrI/hlBZH4XwFWKizI0IEvBpSxOy/71+NBdlnhvLA3c+yCHmf84ZrWgFEunhPYVaSGCbFMts3YlcyH7a1W66GjwRnQKvDievLBWvMCRoypV+QAoKLCMEJj1EAGBwfDrNlWkafcrAb/op15DLhH8DiH6DWsi3sFHU= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iokpp.de; spf=none smtp.mailfrom=iokpp.de; dkim=pass (2048-bit key) header.d=iokpp.de header.i=@iokpp.de header.b=oB5MUOcw; dkim=permerror (0-bit key) header.d=iokpp.de header.i=@iokpp.de header.b=OxctGTOo; arc=pass smtp.client-ip=85.215.255.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iokpp.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=iokpp.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iokpp.de header.i=@iokpp.de header.b="oB5MUOcw"; dkim=permerror (0-bit key) header.d=iokpp.de header.i=@iokpp.de header.b="OxctGTOo" ARC-Seal: i=1; a=rsa-sha256; t=1774257016; cv=none; d=strato.com; s=strato-dkim-0002; b=fCnQxOjBHWAvciIhvDWKGSu1LEvxeGBq1dtQMwfQ/6WAAJnAx3Yp4cEn/ZabU9x/sM GIgqdDNxbQutsjV8oO8lPOLn0DpOb3Bkoq8I0uKtoF4cqWGt+gTdB6X0ByylvHnf8gUR JMKimUSb+RNCcx2n245u3T+748iW+y08/SRCUhsrhZuz7IWewgetlkXiKpxFeF9OMaWA 804UyV/Q/Q9RAubQsnrfP2ieNJ40fkzT5ZJXl/ctRCmY30+9x5QrfVBfPbAKgeoc/nuo dQvcgEg8VW1iU4gK4sOFBovJLylMa5bx9O1TpWqp/V4s5NLxvAvR/ejnFPQbpcDJeibg mPoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1774257016; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Cc:Date: From:Subject:Sender; bh=suw9KHLI1LNKkl/PCLrf2qkeUAqtRJBNl4/N/e6MHDw=; b=j44P6oh9KjaapEvWeWAxinrm23dGpzGc6zQgz8zReYtOa8RQO1OZtijvbstav8i6TH y+e9aUAZguwnx0WsGDuoMcYVUX5ylEtlgqztFbRc8KybT5ARjQynxC4UA7LeXPElPkqr wC1AVGXoNo/vsaKHiJE9i20B3Kr/VSvUMtPkZT3YFWr79PoMgfshTB8yJamJoNXAdAo4 Vks/GHstO1/+Ff+kWLQUyNUbqK03RupBrRmd+PHiMZbqvG03lpDg71c2dg869GrHeBwB 7ILalUn4LJCoSg7K30giTEp1xd4ooKQGr/A3zDJpaxAxSuik5QrqD3SdHKefIB1xqfub PxCQ== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo02 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1774257016; s=strato-dkim-0002; d=iokpp.de; h=References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Cc:Date: From:Subject:Sender; bh=suw9KHLI1LNKkl/PCLrf2qkeUAqtRJBNl4/N/e6MHDw=; b=oB5MUOcwnL8wCWZIvUbSF+n2tSmvY2PVB1F2iP1KO29zhSuG8WjCJd7fd9BCHBLaoO hCZji4UZWVbHd/cymJEyO1S+ozjz244YJBfyKb9vafioRhTGzelXhX4OzKC6kK5nhtL4 YQR79nLITuX5GloZVPJoO/UpMz3kMEQO92qhPnTcL6pc37pfKMniHYxAQAZfa0t7YL1Z S1L3kuaFutU7wdHOboPeeVPCX/vhOxSEJR9ndUkN4paxKvvTF6X72S4NxJju1E+/ZgG5 Z9NH3rqjY80KOT4BKWf7AYDRjw3oVY2qlgM2m1rS0eSuQi0Z8yn0yYbBvO6roGjoWV3Z Vs2w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1774257016; s=strato-dkim-0003; d=iokpp.de; h=References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Cc:Date: From:Subject:Sender; bh=suw9KHLI1LNKkl/PCLrf2qkeUAqtRJBNl4/N/e6MHDw=; b=OxctGTOoYRuBaiR748PWHh5Zf8TwSpWRVyedcUgy/m2eZ9JYyuKBf0kvDe4ia1Uls5 cUNnrJp25Kfa9ukmmCBQ== X-RZG-AUTH: ":LmkFe0i9dN8c2t4QQyGBB/NDXvjDB6pBSe9tgBDSDt0V0DBslXBtZUxPOub3IZqk" Received: from [10.176.235.211] by smtp.strato.de (RZmta 55.0.1 AUTH) with ESMTPSA id z7934522N9ADQJ7 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 23 Mar 2026 10:10:13 +0100 (CET) Message-ID: Subject: Re: [PATCH v4 01/12] scsi: ufs: core: Introduce a new ufshcd vops negotiate_pwr_mode() From: Bean Huo To: Can Guo , avri.altman@wdc.com, bvanassche@acm.org, beanhuo@micron.com, peter.wang@mediatek.com, martin.petersen@oracle.com, mani@kernel.org Cc: linux-scsi@vger.kernel.org, Alim Akhtar , "James E.J. Bottomley" , Sai Krishna Potthuri , Ajay Neeli , Peter Griffin , Krzysztof Kozlowski , Chaotian Jing , Stanley Jhu , Orson Zhai , Baolin Wang , Chunyan Zhang , Matthias Brugger , AngeloGioacchino Del Regno , "Bao D. Nguyen" , Adrian Hunter , Archana Patni , open list , "open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER..." , "moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , "moderated list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER..." , "open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER..." Date: Mon, 23 Mar 2026 10:10:12 +0100 In-Reply-To: <20260321031021.1722459-2-can.guo@oss.qualcomm.com> References: <20260321031021.1722459-1-can.guo@oss.qualcomm.com> <20260321031021.1722459-2-can.guo@oss.qualcomm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu2.1 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2026-03-20 at 20:10 -0700, Can Guo wrote: > Most vendor specific implemenations of vops pwr_change_notify(PRE_CHANGE) > are fulfilling two things at once: > - Vendor specific target power mode negotiation > - Vendor specific power mode change preparation >=20 > When TX Equalization is added into consideration, before power mode chang= e > to a target power mode, TX Equalization Training (EQTR) needs be done for > that target power mode. In addition, UFSHCI spec requires to start TX EQT= R > from HS-G1 (the most reliable High Speed Gear). >=20 > Adding TX EQTR before pwr_change_notify(PRE_CHANGE) is not applicable > because we don't know the negotiated power mode yet. >=20 > Adding TX EQTR post pwr_change_notify(PRE_CHANGE) is inappropriate > because pwr_change_notify(PRE_CHANGE) has finished preparation for a powe= r > mode change to negotiated power mode, yet we are changing power mode to > HS-G1 for TX EQTR. >=20 > Add a new vops negotiate_pwr_mode() so that vendor specific power mode > negotiation can be fulfilled in its vendor specific implementations. > Later on, TX EQTR can be added post vops negotiate_pwr_mode() and before > vops pwr_change_notify(PRE_CHANGE). >=20 > Signed-off-by: Can Guo Looks good to me. Let=E2=80=99s move forward! Reviewed-by: Bean Huo