From: Konrad Dybcio <konradybcio@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Bart Van Assche <bvanassche@acm.org>,
Dmitry Osipenko <digetx@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Viresh Kumar <vireshk@kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Nishanth Menon <nm@ti.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-tegra@vger.kernel.org,
Avri Altman <avri.altman@wdc.com>,
Bjorn Andersson <andersson@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH] OPP: Remove the unused argument to config_clks_t
Date: Thu, 4 Jan 2024 13:56:03 +0100 [thread overview]
Message-ID: <d994e6c3-f69e-4910-b699-65cb3ab6c72b@kernel.org> (raw)
In-Reply-To: <64ee255e-9a5a-405e-b342-e91c55bd95ce@kernel.org>
On 4.01.2024 13:53, Konrad Dybcio wrote:
>
> On 3.01.2024 11:48, Viresh Kumar wrote:
>> The OPP core needs to take care of a special case, where the OPPs aren't
>> available for a device, but in order to keep the same unified interface
>> for the driver, the same OPP core API must take care of performing a
>> simple clk_set_rate() for the device.
>>
>> This required the extra argument, but that is used only within the OPP
>> core and the drivers don't need to take care of that.
>>
>> Simplify the external API and handle it differently within the OPP core.
>>
>> This shouldn't result in any functional change.
> Hi, so this apparently breaks serial on Qualcomm platforms using
> "qcom,geni-debug-uart".. I'm seeing garbage on the console, likely
> meaning that ratesetting wasn't done.
+CC Bjorn, Dmitry
Probably also worth noting it only happens when an OPP table is present
in the device tree.
Konrad
next prev parent reply other threads:[~2024-01-04 12:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 10:48 [PATCH] OPP: Remove the unused argument to config_clks_t Viresh Kumar
2024-01-04 12:53 ` Konrad Dybcio
2024-01-04 12:56 ` Konrad Dybcio [this message]
2024-01-05 10:35 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d994e6c3-f69e-4910-b699-65cb3ab6c72b@kernel.org \
--to=konradybcio@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=cw00.choi@samsung.com \
--cc=digetx@gmail.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=jejb@linux.ibm.com \
--cc=jonathanh@nvidia.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=myungjoo.ham@samsung.com \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox