Re: [PATCH v2] scsi: ufs: core: Fix error return with query response

[Bart Van Assche <bvanassche@acm.org>]

On 1/17/25 6:38 PM, Seunghui Lee wrote:
> There is currently no mechanism to return error from query responses.
> Return the error and print the corresponding error message with it.
> 
> Signed-off-by: Seunghui Lee <sh043.lee@samsung.com>
> ---
> Changes to v1:
> - modify the error message with response in UPIU(Bean Huo's suggestion)
> ---
>   drivers/ufs/core/ufshcd.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 9c26e8767515..97e50bccb95c 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -3118,8 +3118,13 @@ ufshcd_dev_cmd_completion(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
>   	case UPIU_TRANSACTION_QUERY_RSP: {
>   		u8 response = lrbp->ucd_rsp_ptr->header.response;
>   
> -		if (response == 0)
> +		if (response == 0) {
>   			err = ufshcd_copy_query_response(hba, lrbp);
> +		} else {
> +			err = -EINVAL;
> +			dev_err(hba->dev, "%s: unexpected response in Query RSP: %x\n",
> +					__func__, response);
> +		}
>   		break;
>   	}
>   	case UPIU_TRANSACTION_REJECT_UPIU:

Reviewed-by: Bart Van Assche <bvanassche@acm.org>