public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Bean Huo <huobean@gmail.com>
To: Bart Van Assche <bvanassche@acm.org>,
	jejb@linux.ibm.com, martin.petersen@oracle.com,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: beanhuo@micron.com
Subject: Re: [RFC PATCH ] scsi: remove scsi_sdb_cache
Date: Fri, 19 Jun 2020 17:03:47 +0200	[thread overview]
Message-ID: <dc0c3bcf8b77b838316a0c4a53fdddaa476dd0dc.camel@gmail.com> (raw)
In-Reply-To: <acdceada-b183-e41a-8645-aa3716b55236@acm.org>

Hi Bart

Thanks.

On Fri, 2020-06-19 at 07:31 -0700, Bart Van Assche wrote:
> On 2020-06-19 06:10, Bean Huo wrote:
> > @@ -2039,7 +2024,6 @@ scsi_mode_select(struct scsi_device *sdev,
> > int pf, int sp, int modepage,
> >  		real_buffer[1] = data->medium_type;
> >  		real_buffer[2] = data->device_specific;
> >  		real_buffer[3] = data->block_descriptor_length;
> > -	
Here delete a blank line since there are multiple blank lines.
> > 	
> >  
> >  		cmd[0] = MODE_SELECT;
> >  		cmd[4] = len;
> > @@ -2227,7 +2211,7 @@ scsi_device_set_state(struct scsi_device
> > *sdev, enum scsi_device_state state)
> >  			goto illegal;
> >  		}
> >  		break;
> > -			
> > +

Here has trailing whitespace, delete it.

> >  	case SDEV_RUNNING:
> >  		switch (oldstate) {
> >  		case SDEV_CREATED:
> 
> If these whitespace changes are left out, feel free to add:
> 
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>

Bean


      reply	other threads:[~2020-06-19 16:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-19 13:10 [RFC PATCH ] scsi: remove scsi_sdb_cache Bean Huo
2020-06-19 14:31 ` Bart Van Assche
2020-06-19 15:03   ` Bean Huo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc0c3bcf8b77b838316a0c4a53fdddaa476dd0dc.camel@gmail.com \
    --to=huobean@gmail.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox