From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-scsi-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id CC815C4321E
	for <linux-scsi@archiver.kernel.org>; Thu, 24 Nov 2022 14:43:58 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229653AbiKXOn6 (ORCPT <rfc822;linux-scsi@archiver.kernel.org>);
        Thu, 24 Nov 2022 09:43:58 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47198 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229508AbiKXOn5 (ORCPT
        <rfc822;linux-scsi@vger.kernel.org>); Thu, 24 Nov 2022 09:43:57 -0500
Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de [85.215.255.50])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BB727DCAC;
        Thu, 24 Nov 2022 06:43:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1669301029;
    s=strato-dkim-0002; d=iokpp.de;
    h=References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Cc:Date:
    From:Subject:Sender;
    bh=9mSSiDtptJsFoTSp7lizv54G2RctLeBZ81+WxQ164hE=;
    b=UV2zHPK31IW4LXVPLeWIwAdh9qWWjLww8Pk/ASScWONpfibUDcTMALR89ieUugcSAe
    TV0QAuLpYbtKf7Cq7ZaMuC14nNWXFdCPWamsodvThkdBkrTfCp5dNwm1s+50Uo4zpU70
    j0smVd8OT4PZu8JV+ajuNEpssULrD9duJH0K23cogPfHkCqSm2tl6Ivnko7BxnJ4WOb3
    UzxtIRgCyg1cLbNwO+IUEpIqdc8gTbPT3kBH6cnIOpxV3oHc3LmES5XVqCFEeAfI5DCd
    x/uNn0KeBp3QAqS7JDfGZGpJcj4U3FSBrE7+nR1Y57mu3+gSWCKdlAlOXl3FQvKm6xcc
    /4Kw==
Authentication-Results: strato.com;
    dkim=none
X-RZG-AUTH: ":LmkFe0i9dN8c2t4QQyGBB/NDXvjDB6pBSeBwhhSxarlUcu05JCAPyj3VPAceccYJs0uz"
X-RZG-CLASS-ID: mo00
Received: from blinux
    by smtp.strato.de (RZmta 48.2.1 AUTH)
    with ESMTPSA id z9cfbfyAOEhlrR5
        (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits))
        (Client did not present a certificate);
    Thu, 24 Nov 2022 15:43:47 +0100 (CET)
Message-ID: <dc9fab4e390d63f4f48eba5fcef0fc3d27086b7d.camel@iokpp.de>
Subject: Re: [PATCH v2 3/6] ufs: core: Split ufshcd_map_sg
From:   Bean Huo <beanhuo@iokpp.de>
To:     Avri Altman <Avri.Altman@wdc.com>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "tomas.winkler@intel.com" <tomas.winkler@intel.com>,
        "daejun7.park@samsung.com" <daejun7.park@samsung.com>,
        "quic_cang@quicinc.com" <quic_cang@quicinc.com>,
        "quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
        "quic_xiaosenh@quicinc.com" <quic_xiaosenh@quicinc.com>,
        "quic_richardp@quicinc.com" <quic_richardp@quicinc.com>,
        "quic_asutoshd@quicinc.com" <quic_asutoshd@quicinc.com>,
        "hare@suse.de" <hare@suse.de>
Cc:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date:   Thu, 24 Nov 2022 15:43:46 +0100
In-Reply-To: <DM6PR04MB65756D4E5DEAAA95FCA24784FC0D9@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20221120222217.108492-1-beanhuo@iokpp.de>
         <20221120222217.108492-4-beanhuo@iokpp.de>
         <DM6PR04MB65756D4E5DEAAA95FCA24784FC0D9@DM6PR04MB6575.namprd04.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-scsi.vger.kernel.org>
X-Mailing-List: linux-scsi@vger.kernel.org

On Tue, 2022-11-22 at 08:15 +0000, Avri Altman wrote:
> > +
> > +       cmd = lrbp->cmd;
> > +       sg_segments = scsi_dma_map(cmd);
> 
> Maybe initialize in declaration?

yes, agree, will change it in the next version

Kind regards,
Bean