From: Bart Van Assche <bvanassche@acm.org>
To: John Garry <john.g.garry@oracle.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH] scsi: core: Fix a regression triggered by scsi_host_busy()
Date: Wed, 8 Oct 2025 10:53:28 -0700 [thread overview]
Message-ID: <dcacefc5-110c-48a4-9114-1bc0fab0d649@acm.org> (raw)
In-Reply-To: <3cea82dd-197c-4aa7-9a9c-8908d2f41db8@oracle.com>
On 10/8/25 12:03 AM, John Garry wrote:
> On 07/10/2025 22:48, Bart Van Assche wrote:
>> Commit 995412e23bb2 ("blk-mq: Replace tags->lock with SRCU for tag
>> iterators") introduced the following regression:
>>
>> Call trace:
>> __srcu_read_lock+0x30/0x80 (P)
>> blk_mq_tagset_busy_iter+0x44/0x300
>> scsi_host_busy+0x38/0x70
>
> this value is readable from sysfs, so why even print it?
That's an interesting question. The infrastructure for reporting Android
bugs includes the kernel logs in a bug report but not the values of
sysfs attributes. Hence, if something unexpected happens, having state
information available in the kernel log helps more than having it
available in sysfs. That being said, I think that the UFS kernel driver
reports more information than it should when an unexpected condition is
met, e.g. a link startup failure or starting the UFS error handler.
Bart.
next prev parent reply other threads:[~2025-10-08 17:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 21:48 [PATCH] scsi: core: Fix a regression triggered by scsi_host_busy() Bart Van Assche
2025-10-08 3:17 ` Ming Lei
2025-10-08 5:50 ` Christoph Hellwig
2025-10-08 12:49 ` Sebastian Reichel
2025-10-08 15:48 ` Bart Van Assche
2025-10-08 15:42 ` Bart Van Assche
2025-10-08 7:03 ` John Garry
2025-10-08 17:53 ` Bart Van Assche [this message]
2025-10-08 12:33 ` Sebastian Reichel
2025-10-22 2:26 ` Martin K. Petersen
2025-10-22 8:13 ` John Garry
2025-10-22 18:07 ` Bart Van Assche
2025-10-23 8:31 ` John Garry
2025-10-23 16:32 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcacefc5-110c-48a4-9114-1bc0fab0d649@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@kernel.dk \
--cc=john.g.garry@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).