From: Bart Van Assche <bvanassche@acm.org>
To: peter.wang@mediatek.com, stanley.chu@mediatek.com,
linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
avri.altman@wdc.com, alim.akhtar@samsung.com, jejb@linux.ibm.com
Cc: wsd_upstream@mediatek.com, linux-mediatek@lists.infradead.org,
chun-hung.wu@mediatek.com, alice.chao@mediatek.com,
cc.chou@mediatek.com, chaotian.jing@mediatek.com,
jiajie.hao@mediatek.com, powen.kao@mediatek.com,
jonathan.hsu@mediatek.com, qilin.tan@mediatek.com,
lin.gui@mediatek.com
Subject: Re: [PATCH v1] scsi: ufs: ufs-mediatek: Change dbg select by check hw version
Date: Mon, 30 Aug 2021 19:47:35 -0700 [thread overview]
Message-ID: <dda8eb67-fe56-8bc0-5ce8-a62bd4e6b995@acm.org> (raw)
In-Reply-To: <1630325486-11741-1-git-send-email-peter.wang@mediatek.com>
On 8/30/21 05:11, peter.wang@mediatek.com wrote:
> +static void ufs_mtk_dbg_sel(struct ufs_hba *hba)
> +{
> + static u32 hw_ver;
> +
> + if (!hw_ver)
> + hw_ver = ufshcd_readl(hba, REG_UFS_MTK_HW_VER);
> +
> + if (((hw_ver >> 16) & 0xFF) >= 0x36) {
> + ufshcd_writel(hba, 0x820820, REG_UFS_DEBUG_SEL);
> + ufshcd_writel(hba, 0x0, REG_UFS_DEBUG_SEL_B0);
> + ufshcd_writel(hba, 0x55555555, REG_UFS_DEBUG_SEL_B1);
> + ufshcd_writel(hba, 0xaaaaaaaa, REG_UFS_DEBUG_SEL_B2);
> + ufshcd_writel(hba, 0xffffffff, REG_UFS_DEBUG_SEL_B3);
> + } else {
> + ufshcd_writel(hba, 0x20, REG_UFS_DEBUG_SEL);
> + }
> +}
Can ufs_mtk_dbg_sel() be called from multiple threads at the same time?
Does the 'hw_ver' variable need to be protected against concurrent writes?
Thanks,
Bart.
next prev parent reply other threads:[~2021-08-31 2:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 12:11 [PATCH v1] scsi: ufs: ufs-mediatek: Change dbg select by check hw version peter.wang
2021-08-31 2:47 ` Bart Van Assche [this message]
2021-09-01 2:29 ` Peter Wang
2021-09-01 2:55 ` Bart Van Assche
2021-09-01 5:45 ` Peter Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dda8eb67-fe56-8bc0-5ce8-a62bd4e6b995@acm.org \
--to=bvanassche@acm.org \
--cc=alice.chao@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=jiajie.hao@mediatek.com \
--cc=jonathan.hsu@mediatek.com \
--cc=lin.gui@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=peter.wang@mediatek.com \
--cc=powen.kao@mediatek.com \
--cc=qilin.tan@mediatek.com \
--cc=stanley.chu@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox