From: John Garry <john.garry@huawei.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
James Bottomley <jejb@linux.ibm.com>,
Martin Petersen <martin.petersen@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 0/7] SCSI: cleanup debugfs usage
Date: Wed, 23 Jan 2019 09:23:55 +0000 [thread overview]
Message-ID: <de49a145-cdbe-75a4-da8a-e2d376baad19@huawei.com> (raw)
In-Reply-To: <20190122150906.12470-1-gregkh@linuxfoundation.org>
On 22/01/2019 15:08, Greg Kroah-Hartman wrote:
> When calling debugfs code, there is no need to ever check the return
> value of the call, as no logic should ever change if a call works
> properly or not. Fix up a bunch of x86-specific code to not care about
> the results of debugfs.
>
> Greg Kroah-Hartman (7):
> scsi: bfa: no need to check return value of debugfs_create functions
> scsi: csiostor: no need to check return value of debugfs_create
> functions
> scsi: fnic: no need to check return value of debugfs_create functions
> scsi: snic: no need to check return value of debugfs_create functions
> scsi: lpfc: no need to check return value of debugfs_create functions
> scsi: qlogic: no need to check return value of debugfs_create
> functions
> scsi: qla2xxx: no need to check return value of debugfs_create
> functions
>
JFYI, Martin has some more debugfs usage queued for 5.1 here:
https://kernel.googlesource.com/pub/scm/linux/kernel/git/mkp/scsi/+log/5.1/scsi-queue/drivers/scsi/hisi_sas
I'll send a patch to tidy-up, as above. It would not be x86 specific,
but I am not sure what above is.
Thanks,
John
> drivers/scsi/bfa/bfad_debugfs.c | 17 ---
> drivers/scsi/csiostor/csio_init.c | 6 +-
> drivers/scsi/fnic/fnic_debugfs.c | 88 +---------------
> drivers/scsi/fnic/fnic_main.c | 7 +-
> drivers/scsi/fnic/fnic_stats.h | 2 +-
> drivers/scsi/fnic/fnic_trace.c | 17 +--
> drivers/scsi/fnic/fnic_trace.h | 4 +-
> drivers/scsi/lpfc/lpfc_debugfs.c | 170 ------------------------------
> drivers/scsi/qedf/qedf_debugfs.c | 18 +---
> drivers/scsi/qedi/qedi_debugfs.c | 17 +--
> drivers/scsi/qla2xxx/qla_dfs.c | 43 +-------
> drivers/scsi/snic/snic_debugfs.c | 133 +++++------------------
> drivers/scsi/snic/snic_main.c | 14 +--
> drivers/scsi/snic/snic_stats.h | 2 +-
> drivers/scsi/snic/snic_trc.c | 12 +--
> drivers/scsi/snic/snic_trc.h | 4 +-
> 16 files changed, 48 insertions(+), 506 deletions(-)
>
next prev parent reply other threads:[~2019-01-23 9:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 15:08 [PATCH 0/7] SCSI: cleanup debugfs usage Greg Kroah-Hartman
2019-01-22 15:09 ` [PATCH 1/7] scsi: bfa: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-01-22 15:09 ` [PATCH 2/7] scsi: csiostor: " Greg Kroah-Hartman
2019-01-24 9:22 ` Johannes Thumshirn
2019-01-22 15:09 ` [PATCH 3/7] scsi: fnic: " Greg Kroah-Hartman
2019-01-22 18:05 ` Satish Kharat (satishkh)
2019-01-22 15:09 ` [PATCH 4/7] scsi: snic: " Greg Kroah-Hartman
2019-01-22 15:09 ` [PATCH 5/7] scsi: lpfc: " Greg Kroah-Hartman
2019-01-22 15:09 ` [PATCH 6/7] scsi: qlogic: " Greg Kroah-Hartman
2019-01-23 5:36 ` Manish Rangankar
2019-01-22 15:09 ` [PATCH 7/7] scsi: qla2xxx: " Greg Kroah-Hartman
2019-01-23 9:23 ` John Garry [this message]
2019-01-29 5:37 ` [PATCH 0/7] SCSI: cleanup debugfs usage Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de49a145-cdbe-75a4-da8a-e2d376baad19@huawei.com \
--to=john.garry@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox