From: Adrian Hunter <adrian.hunter@intel.com>
To: Bart Van Assche <bvanassche@acm.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
Avri Altman <avri.altman@wdc.com>,
linux-scsi@vger.kernel.org, Asutosh Das <asutoshd@codeaurora.org>,
Tomas Henzl <thenzl@redhat.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Bart Van Assche <bvanassche@google.com>,
Bean Huo <beanhuo@micron.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Asutosh Das <quic_asutoshd@quicinc.com>
Subject: Re: [PATCH v2 2/4] scsi: ufs: Simplify ufshcd_wl_shutdown()
Date: Wed, 19 Apr 2023 08:23:29 +0300 [thread overview]
Message-ID: <de72eb42-f0f9-99c3-2e14-e8ab00d3f39a@intel.com> (raw)
In-Reply-To: <be06f246-a69e-ade7-0318-5a99d2d36216@acm.org>
On 18/04/23 23:14, Bart Van Assche wrote:
> On 4/18/23 07:13, Adrian Hunter wrote:
>> On 18/04/23 17:06, Bart Van Assche wrote:
>>> On 4/18/23 06:45, Adrian Hunter wrote:
>>>> On 18/04/23 02:06, Bart Van Assche wrote:
>>>>> Now that sd_shutdown() fails future I/O the code for quiescing LUNs in
>>>>> ufshcd_wl_shutdown() is superfluous. Remove the code for quiescing LUNs.
>>>>> Also remove the ufshcd_rpm_get_sync() call because it is not necessary
>>>>> to resume a UFS device before submitting a START STOP UNIT command.
>>>>
>>>> What about the host controller hba->dev?
>>>
>>> The above question is not clear to me. Please elaborate.
>>
>> Does hba->dev need to be runtime resumed?
>
> Hi Adrian,
>
> I don't think so. Shutdown callback functions are expected to quiesce hardware activity. To me runtime resuming a device seems to contradict the goal of quiescing hardware activity.
I don't think the host controller can be used to submit a START STOP UNIT command if the host controller is runtime suspended.
next prev parent reply other threads:[~2023-04-19 5:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 23:06 [PATCH v2 0/4] SCSI core and UFS patches for kernel v6.4 Bart Van Assche
2023-04-17 23:06 ` [PATCH v2 1/4] scsi: sd: Let sd_shutdown() fail future I/O Bart Van Assche
2023-04-18 4:37 ` Ming Lei
2023-04-18 14:09 ` Bart Van Assche
2023-04-18 5:06 ` Christoph Hellwig
2023-04-18 14:36 ` James Bottomley
2023-04-18 18:37 ` Bart Van Assche
2023-04-19 2:34 ` James Bottomley
2023-04-19 13:36 ` Tomas Henzl
2023-04-19 14:02 ` James Bottomley
2023-04-19 17:58 ` Bart Van Assche
2023-04-19 18:33 ` James Bottomley
2023-04-19 19:24 ` Bart Van Assche
2023-04-19 19:29 ` James Bottomley
2023-04-17 23:06 ` [PATCH v2 2/4] scsi: ufs: Simplify ufshcd_wl_shutdown() Bart Van Assche
2023-04-18 13:45 ` Adrian Hunter
2023-04-18 14:06 ` Bart Van Assche
2023-04-18 14:13 ` Adrian Hunter
2023-04-18 20:14 ` Bart Van Assche
2023-04-19 5:23 ` Adrian Hunter [this message]
2023-04-17 23:06 ` [PATCH v2 3/4] scsi: ufs: Increase the START STOP UNIT timeout from one to ten seconds Bart Van Assche
2023-04-18 7:30 ` Adrian Hunter
2023-04-18 7:57 ` Stanley Chu
2023-04-17 23:06 ` [PATCH v2 4/4] scsi: ufs: Fix handling of lrbp->cmd Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de72eb42-f0f9-99c3-2e14-e8ab00d3f39a@intel.com \
--to=adrian.hunter@intel.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=bvanassche@google.com \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_asutoshd@quicinc.com \
--cc=stanley.chu@mediatek.com \
--cc=thenzl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox