Re: [PATCH v2 45/84] libsas: Call scsi_done() directly

John Garry
2021-09-30T18:06:25Z

On 29/09/2021 23:05, Bart Van Assche wrote:
> Conditional statements are faster than indirect calls. Hence call
> scsi_done() directly.
>
> Reviewed-by: Lee Duncan <lduncanb@suse.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>

Hi Bart,

Can you double-check these tags, as I know I provided a RB tag, but I'm
not sure about Lee?

Thanks

> ---
> drivers/scsi/libsas/sas_scsi_host.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c
> index 2bf37151623e..d337fdf1b9ca 100644
> --- a/drivers/scsi/libsas/sas_scsi_host.c
> +++ b/drivers/scsi/libsas/sas_scsi_host.c
> @@ -125,7 +125,7 @@ static void sas_scsi_task_done(struct sas_task *task)
> }
>
> sas_end_task(sc, task);
> - sc->scsi_done(sc);
> + scsi_done(sc);
> }
>
> static struct sas_task *sas_create_task(struct scsi_cmnd *cmd,
> @@ -198,7 +198,7 @@ int sas_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd)
> else
> cmd->result = DID_ERROR << 16;
> out_done:
> - cmd->scsi_done(cmd);
> + scsi_done(cmd);
> return 0;
> }
> EXPORT_SYMBOL_GPL(sas_queuecommand);
> .
>