Re: [PATCH v2 57/84] nsp32: Call scsi_done() directly

Masanori Goto
2021-10-04T04:15:20Z

Indeed this is a no-op change, but in a different thread, one
interesting question raised was to remove scsi_done* in the argument
of queuecommand_lck, so that the change is much cleaner and generic.
Could you conduct a research on whether it's removal or not? I'd like
to hear from the overall SCSI maintainer perspective too.
Also, I'm curious why the IOPS was improved - what kind of device
drives did you use? Specifically, nsp32 was designed for PCI based
devices so it cannot handle millions of QPS - so this change has
unlikely an impact to the performance gain. This comes back to the
first scsi_done question on whether this overall framework should be
changed or not.