Re: [PATCH v2 01/84] scsi: core: Use a member variable to track the SCSI command submitter

Bean Huo
2021-10-03T21:08:59Z

On Wed, 2021-09-29 at 15:04 -0700, Bart Van Assche wrote:
> Conditional statements are faster than indirect calls. Use a member
> variable
>
> to track the SCSI command submitter such that later patches can call
>
> scsi_done(scmd) instead of scmd->scsi_done(scmd).
>
>
>
> The asymmetric behavior that scsi_send_eh_cmnd() sets the submission
>
> context to the SCSI error handler and that it does not restore the
>
> submission context to the SCSI core is retained.
>
>
>
> Cc: Hannes Reinecke <hare@suse.com>
>
> Cc: Ming Lei <ming.lei@redhat.com>
>
> Cc: Christoph Hellwig <hch@lst.de>
>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>

Reviewed-by: Bean Huo <beanhuo@micron.com>