RE: [PATCH v2 72/84] storvsc_drv: Call scsi_done() directly

Haiyang Zhang
2021-09-30T17:57:57Z

> -----Original Message-----
> From: Bart Van Assche <bvanassche@acm.org>
> Sent: Wednesday, September 29, 2021 6:06 PM
> To: Martin K . Petersen <martin.petersen@oracle.com>
> Cc: linux-scsi@vger.kernel.org; Bart Van Assche <bvanassche@acm.org>; KY
> Srinivasan <kys@microsoft.com>; Haiyang Zhang <haiyangz@microsoft.com>;
> Stephen Hemminger <sthemmin@microsoft.com>; Wei Liu <wei.liu@kernel.org>;
> Dexuan Cui <decui@microsoft.com>; James E.J. Bottomley
> <jejb@linux.ibm.com>
> Subject: [PATCH v2 72/84] storvsc_drv: Call scsi_done() directly
>
> Conditional statements are faster than indirect calls. Hence call
> scsi_done() directly.
>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/scsi/storvsc_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index ebbbc1299c62..70d0b1dd0f75 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -1154,7 +1154,7 @@ static void storvsc_command_completion(struct
> storvsc_cmd_request *cmd_request,
> scsi_set_resid(scmnd,
> cmd_request->payload->range.len - data_transfer_length);
>
> - scmnd->scsi_done(scmnd);
> + scsi_done(scmnd);
>
> if (payload_sz >
> sizeof(struct vmbus_channel_packet_multipage_buffer))
> @@ -1753,7 +1753,7 @@ static int storvsc_queuecommand(struct Scsi_Host
> *host, struct scsi_cmnd *scmnd)
> * future versions of the host.
> */
> if (!storvsc_scsi_cmd_ok(scmnd)) {
> - scmnd->scsi_done(scmnd);
> + scsi_done(scmnd);
> return 0;
> }
> }

Thanks.
Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>