Re: [PATCH v1] ufs: core: fix deadlock when rtc update

Bean Huo
2024-07-13T20:17:17Z

On Fri, 2024-07-12 at 12:31 +0000, Avri Altman wrote:
> > > >           hba = container_of(to_delayed_work(work), struct
> > > > ufs_hba,
> > > > ufs_rtc_update_work);
> > > Will returning here If (!ufshcd_is_ufs_dev_active(hba)) works?
> > > And remove it in the 2nd if clause?
> >
> > Avri,
> >
> > we need to reschedule next time work in the below code.  if return,
> > cannot.
> >
> > whatelse I missed?
> a) If (!ufshcd_is_ufs_dev_active(hba)) - will not schedule ?
> b) schedule on next __ufshcd_wl_resume?

hba->pm_op_in_progress is true during __ufshcd_wl_resume(), will not
schedule update work.