From: Yum Rayan <yum.rayan@gmail.com>
To: dougg@torque.net
Cc: linux-scsi@vger.kernel.org, bunk@stusta.de,
James.Bottomley@steeleye.com, rddunlap@osdl.org
Subject: Re: [2.6 patch] drivers/scsi/sg.c: several against 2.6.12-rc1
Date: Mon, 28 Mar 2005 20:46:14 -0800 [thread overview]
Message-ID: <df35dfeb05032820467ee1ad4c@mail.gmail.com> (raw)
In-Reply-To: <4247D2DA.5010009@torque.net>
In the diff
>+ if (old_hdr)
>+ kfree(old_hdr);
>+ return retval;
The check for NULL is not needed.
Thanks,
Rayan
On Mon, 28 Mar 2005 19:48:10 +1000, Douglas Gilbert <dougg@torque.net> wrote:
> The attachment combines the most recent patch from
> Yum Rayan <yum.rayan@gmail.com> (to reduce sg stack
> usage), Adrian Bunk <bunk@stusta.de> (to fix check
> after use) and me (fix elapsed time calculation
> (duration) on ia64 machines).
>
> I have modified the patch from Yum Rayan so kmalloc()
> in sg_read() is only called for the (rare) code paths
> that need them.
>
> Changelog:
> - reduce stack usage in sg_ioctl() and sg_read()
> - fix check after use in sg_mmap()
> - hold duration internally in milliseconds and
> check current time later than held time
>
> Signed-off-by: Douglas Gilbert <dougg@torque.net>
>
>
>
prev parent reply other threads:[~2005-03-29 4:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-28 9:48 [2.6 patch] drivers/scsi/sg.c: several against 2.6.12-rc1 Douglas Gilbert
2005-03-29 4:46 ` Yum Rayan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df35dfeb05032820467ee1ad4c@mail.gmail.com \
--to=yum.rayan@gmail.com \
--cc=James.Bottomley@steeleye.com \
--cc=bunk@stusta.de \
--cc=dougg@torque.net \
--cc=linux-scsi@vger.kernel.org \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox