From: Hannes Reinecke <hare@suse.de>
To: Douglas Gilbert <dgilbert@interlog.com>, linux-scsi@vger.kernel.org
Cc: martin.petersen@oracle.com, jejb@linux.vnet.ibm.com,
Damien.LeMoal@wdc.com
Subject: Re: [PATCH v21 45/46] sg: add statistics similar to st
Date: Mon, 4 Oct 2021 07:59:24 +0200 [thread overview]
Message-ID: <e08cb9e8-80be-689b-19ac-d8c5bcfbe54e@suse.de> (raw)
In-Reply-To: <20211003163151.585349-46-dgilbert@interlog.com>
On 10/3/21 6:31 PM, Douglas Gilbert wrote:
> Using the existing statistics gathering framework from the st
> driver, collect statistics for access via sysfs. The sysstat
> package already has a utility called tapestat for presenting
> st statistics. Its author is keen to use the existing
> tapestat code for showing sg statistics (rather than write a
> new utility).
>
> In keeping with the sg driver being SCSI command agnostic, the
> "read" statistics are compiled for requests that have "data-in"
> user data while write statistics are compiled for requests that
> have "data-out" user data.
>
> Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>
> ---
> drivers/scsi/sg.c | 260 ++++++++++++++++++++++++++++++++++++++++------
> 1 file changed, 228 insertions(+), 32 deletions(-)
> Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2021-10-04 5:59 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 16:31 [PATCH v21 00/46] sg: add v4 interface Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 01/46] sg: move functions around Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 02/46] sg: remove typedefs, type+formatting cleanup Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 03/46] sg: sg_log and is_enabled Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 04/46] sg: rework sg_poll(), minor changes Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 05/46] sg: bitops in sg_device Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 06/46] sg: make open count an atomic Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 07/46] sg: move header to uapi section Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 08/46] sg: speed sg_poll and sg_get_num_waiting Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 09/46] sg: sg_allow_if_err_recovery and renames Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 10/46] sg: improve naming Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 11/46] sg: change rwlock to spinlock Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 12/46] sg: ioctl handling Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 13/46] sg: split sg_read Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 14/46] sg: sg_common_write add structure for arguments Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 15/46] sg: rework sg_vma_fault Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 16/46] sg: rework sg_mmap Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 17/46] sg: replace sg_allow_access Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 18/46] sg: rework scatter gather handling Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 19/46] sg: introduce request state machine Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 20/46] sg: sg_find_srp_by_id Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 21/46] sg: sg_fill_request_element Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 22/46] sg: printk change %p to %pK Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 23/46] sg: xarray for fds in device Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 24/46] sg: xarray for reqs in fd Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 25/46] sg: replace rq array with xarray Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 26/46] sg: sense buffer rework Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 27/46] sg: add sg v4 interface support Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 28/46] sg: rework debug info Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 29/46] sg: add 8 byte SCSI LUN to sg_scsi_id Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 30/46] sg: expand sg_comm_wr_t Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 31/46] sg: add sg_iosubmit_v3 and sg_ioreceive_v3 ioctls Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 32/46] sg: add some __must_hold macros Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 33/46] sg: move procfs objects to avoid forward decls Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 34/46] sg: protect multiple receivers Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 35/46] sg: first debugfs support Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 36/46] sg: rework mmap support Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 37/46] sg: defang allow_dio Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 38/46] sg: warn v3 write system call users Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 39/46] sg: add mmap_sz tracking Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 40/46] sg: remove rcv_done request state Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 41/46] sg: track lowest inactive and await indexes Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 42/46] sg: remove unit attention check for device changed Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 43/46] sg: no_dxfer: move to/from kernel buffers Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 44/46] sg: add blk_poll support Douglas Gilbert
2021-10-03 16:31 ` [PATCH v21 45/46] sg: add statistics similar to st Douglas Gilbert
2021-10-04 5:59 ` Hannes Reinecke [this message]
2021-10-05 3:34 ` Damien Le Moal
2021-10-03 16:31 ` [PATCH v21 46/46] sg: bump version to 4.0.12 Douglas Gilbert
2021-10-04 7:07 ` [PATCH v21 00/46] sg: add v4 interface Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e08cb9e8-80be-689b-19ac-d8c5bcfbe54e@suse.de \
--to=hare@suse.de \
--cc=Damien.LeMoal@wdc.com \
--cc=dgilbert@interlog.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox