From: Bean Huo <beanhuo@iokpp.de>
To: Arthur Simchaev <Arthur.Simchaev@wdc.com>, martin.petersen@oracle.com
Cc: beanhuo@micron.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/4] ufs: core: Remove len parameter from ufshcd_set_active_icc_lvl
Date: Wed, 23 Nov 2022 18:18:10 +0100 [thread overview]
Message-ID: <e0d77da04feaa39addf679df9d0964ed180cd06a.camel@iokpp.de> (raw)
In-Reply-To: <1669045590-26101-4-git-send-email-Arthur.Simchaev@wdc.com>
On Mon, 2022-11-21 at 17:46 +0200, Arthur Simchaev wrote:
> len argument is not used anymore in ufshcd_set_active_icc_lvl
> function.
>
> Signed-off-by: Arthur Simchaev <Arthur.Simchaev@wdc.com>
> ---
> drivers/ufs/core/ufshcd.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 7456aa2..604348f 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -7391,12 +7391,11 @@ static u32 ufshcd_get_max_icc_level(int
> sup_curr_uA, u32 start_scan,
> * In case regulators are not initialized we'll return 0
> * @hba: per-adapter instance
> * @desc_buf: power descriptor buffer to extract ICC levels from.
> - * @len: length of desc_buff
> *
> * Returns calculated ICC level
> */
> static u32 ufshcd_find_max_sup_active_icc_level(struct ufs_hba *hba,
> - const u8 *desc_buf, int
> len)
> + const u8 *desc_buf)
The Linux kernel already deprecates the 80 character per line coding
style, so you could keep one line here after removing len.
Reviewed-by: Bean Huo <beanhuo@micron.com>
next prev parent reply other threads:[~2022-11-23 17:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 15:46 [PATCH v2 0/4] ufs: core: Always read the descriptors with max length Arthur Simchaev
2022-11-21 15:46 ` [PATCH v3 1/4] ufs: core: Remove redundant wb check Arthur Simchaev
2022-11-23 16:43 ` Bean Huo
2022-11-21 15:46 ` [PATCH v3 2/4] ufs: core: Remove redundant desc_size variable from hba Arthur Simchaev
2022-11-23 17:10 ` Bean Huo
2022-11-21 15:46 ` [PATCH v3 3/4] ufs: core: Remove len parameter from ufshcd_set_active_icc_lvl Arthur Simchaev
2022-11-23 17:18 ` Bean Huo [this message]
2022-11-21 15:46 ` [PATCH v3 4/4] ufs: core: Remove ufshcd_map_desc_id_to_length function Arthur Simchaev
2022-11-23 17:31 ` Bean Huo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0d77da04feaa39addf679df9d0964ed180cd06a.camel@iokpp.de \
--to=beanhuo@iokpp.de \
--cc=Arthur.Simchaev@wdc.com \
--cc=beanhuo@micron.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox