From: Sumit Saxena <sumit.saxena@avagotech.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-scsi@vger.kernel.org, thenzl@redhat.com,
martin.petersen@oracle.com, jbottomley@parallels.com,
Kashyap Desai <kashyap.desai@avagotech.com>
Subject: RE: [PATCH RESEND 6/18] megaraid_sas : Use Block layer tag support for internal command indexing
Date: Tue, 21 Apr 2015 18:03:14 +0530 [thread overview]
Message-ID: <e1ce6d2a2c88186f3d665bd9d8133c1f@mail.gmail.com> (raw)
In-Reply-To: <20150421104210.GC8920@infradead.org>
>-----Original Message-----
>From: Christoph Hellwig [mailto:hch@infradead.org]
>Sent: Tuesday, April 21, 2015 4:12 PM
>To: Sumit.Saxena@avagotech.com
>Cc: linux-scsi@vger.kernel.org; thenzl@redhat.com;
>martin.petersen@oracle.com; hch@infradead.org;
>jbottomley@parallels.com; kashyap.desai@avagotech.com
>Subject: Re: [PATCH RESEND 6/18] megaraid_sas : Use Block layer tag
support
>for internal command indexing
>
>This patch needs to be split up: the return_cmd calling convenion
changes
>should be a pach on it's own, the various new debug printks should be a
patch
>on their own, or better jsut be dropped.
I can work on this. Logically, there can be two patches- 1) BLK tag
support 2) changes in calling convention of return_cmd (this patch will
revert the changes done by patch- 90dc9d9 megaraid_sas : MFI MPT linked
list corruption fix).
So patch #2 will be very much dependent on patch #1. If someone applies
patch #2 without applying patch#1, then bug fixed by "90dc9d9
megaraid_sas : MFI MPT linked list corruption fix " will be exposed again.
That's why I club these two patches in a single patch. Regarding debug
prints, that can be removed.
>
>Also please drop the BLK_TAG_REFCOUNT/DEBUG code that shouldn't be ina
>production driver.
next prev parent reply other threads:[~2015-04-21 12:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 12:33 [PATCH RESEND 6/18] megaraid_sas : Use Block layer tag support for internal command indexing Sumit.Saxena
2015-04-21 10:26 ` Hannes Reinecke
2015-04-21 10:42 ` Christoph Hellwig
2015-04-21 12:33 ` Sumit Saxena [this message]
2015-04-22 11:32 ` Sumit Saxena
2015-04-22 11:40 ` Christoph Hellwig
2015-04-22 12:04 ` Sumit Saxena
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1ce6d2a2c88186f3d665bd9d8133c1f@mail.gmail.com \
--to=sumit.saxena@avagotech.com \
--cc=hch@infradead.org \
--cc=jbottomley@parallels.com \
--cc=kashyap.desai@avagotech.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=thenzl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).