From: Damien Le Moal <dlemoal@kernel.org>
To: Bart Van Assche <bvanassche@acm.org>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>, Ming Lei <ming.lei@redhat.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>
Subject: Re: [PATCH v14 10/19] scsi: core: Retry unaligned zoned writes
Date: Wed, 25 Oct 2023 16:25:43 +0900 [thread overview]
Message-ID: <e3e92b62-ebeb-42d1-8857-c66721c0325e@kernel.org> (raw)
In-Reply-To: <7027b9b9-80cb-418a-8510-b4104a8cdadf@acm.org>
On 10/25/23 02:22, Bart Van Assche wrote:
> On 10/23/23 17:13, Damien Le Moal wrote:
>> On 10/24/23 06:54, Bart Van Assche wrote:
>>> case ILLEGAL_REQUEST:
>>> + /*
>>> + * Unaligned write command. This may indicate that zoned writes
>>> + * have been received by the device in the wrong order. If zone
>>> + * write locking is disabled, retry after all pending commands
>>> + * have completed.
>>> + */
>>> + if (sshdr.asc == 0x21 && sshdr.ascq == 0x04 &&
>>> + !req->q->limits.use_zone_write_lock &&
>>> + blk_rq_is_seq_zoned_write(req) &&
>>> + scmd->retries <= scmd->allowed) {
>>> + sdev_printk(KERN_INFO, scmd->device,
>>> + "Retrying unaligned write at LBA %#llx.\n",
>>> + scsi_get_lba(scmd));
>>
>> KERN_INFO ? Did you perhaps mean KERN_DEBUG ? An info message for this will be
>> way too noisy.
>
> Hi Damien,
>
> Are you sure that KERN_INFO will be too noisy? On our test setups we see
> this message less than once a day. Anyway, I will change the severity level.
I am not sure. But better safe than sorry :)
So given that we should not scare the user with errors that are not errors (as
the next tries will succeed), we should be silent and log a message only if the
retry count is exhausted and we still see a failure.
>
> Bart.
>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2023-10-25 7:25 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 21:53 [PATCH v14 00/19] Improve write performance for zoned UFS devices Bart Van Assche
2023-10-23 21:53 ` [PATCH v14 01/19] block: Introduce more member variables related to zone write locking Bart Van Assche
2023-10-23 21:53 ` [PATCH v14 02/19] block: Only use write locking if necessary Bart Van Assche
2023-10-23 23:29 ` Damien Le Moal
2023-10-23 21:53 ` [PATCH v14 03/19] block: Preserve the order of requeued zoned writes Bart Van Assche
2023-10-23 23:30 ` Damien Le Moal
2023-10-23 21:53 ` [PATCH v14 04/19] block/mq-deadline: Only use zone locking if necessary Bart Van Assche
2023-10-23 21:53 ` [PATCH v14 05/19] scsi: Add an argument to scsi_eh_flush_done_q() Bart Van Assche
2023-10-24 0:07 ` Damien Le Moal
2023-10-24 9:26 ` John Garry
2023-10-24 17:17 ` Bart Van Assche
2023-10-24 18:20 ` John Garry
2023-10-23 21:53 ` [PATCH v14 06/19] scsi: core: Introduce a mechanism for reordering requests in the error handler Bart Van Assche
2023-10-24 0:09 ` Damien Le Moal
2023-10-23 21:53 ` [PATCH v14 07/19] scsi: core: Add unit tests for scsi_call_prepare_resubmit() Bart Van Assche
2023-10-23 21:53 ` [PATCH v14 08/19] scsi: sd: Sort commands by LBA before resubmitting Bart Van Assche
2023-10-24 0:11 ` Damien Le Moal
2023-10-23 21:54 ` [PATCH v14 09/19] scsi: sd: Add a unit test for sd_cmp_sector() Bart Van Assche
2023-10-23 21:54 ` [PATCH v14 10/19] scsi: core: Retry unaligned zoned writes Bart Van Assche
2023-10-24 0:13 ` Damien Le Moal
2023-10-24 17:22 ` Bart Van Assche
2023-10-25 7:25 ` Damien Le Moal [this message]
2023-10-25 19:28 ` Bart Van Assche
2023-10-23 21:54 ` [PATCH v14 11/19] scsi: sd_zbc: Only require an I/O scheduler if needed Bart Van Assche
2023-10-23 21:54 ` [PATCH v14 12/19] scsi: scsi_debug: Add the preserves_write_order module parameter Bart Van Assche
2023-10-24 0:13 ` Damien Le Moal
2023-10-24 17:25 ` Bart Van Assche
2023-10-23 21:54 ` [PATCH v14 13/19] scsi: scsi_debug: Support injecting unaligned write errors Bart Van Assche
2023-10-23 21:54 ` [PATCH v14 14/19] scsi: ufs: hisi: Rework the code that disables auto-hibernation Bart Van Assche
2023-10-23 21:54 ` [PATCH v14 15/19] scsi: ufs: Rename ufshcd_auto_hibern8_enable() and make it static Bart Van Assche
2023-10-23 21:54 ` [PATCH v14 16/19] scsi: ufs: Change the return type of ufshcd_auto_hibern8_update() Bart Van Assche
2023-10-23 21:54 ` [PATCH v14 17/19] scsi: ufs: Simplify ufshcd_auto_hibern8_update() Bart Van Assche
2023-10-23 21:54 ` [PATCH v14 18/19] scsi: ufs: Forbid auto-hibernation without I/O scheduler Bart Van Assche
2023-10-23 21:54 ` [PATCH v14 19/19] scsi: ufs: Inform the block layer about write ordering Bart Van Assche
2023-10-23 23:43 ` [PATCH v14 00/19] Improve write performance for zoned UFS devices Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3e92b62-ebeb-42d1-8857-c66721c0325e@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox