From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: [PATCH 3/3] xen-scsiback: Pass a failure indication as a constant Date: Sat, 16 Jul 2016 22:24:54 +0200 Message-ID: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <59e51c7d-f7bb-c55f-d2fe-06dccfef6a99@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <59e51c7d-f7bb-c55f-d2fe-06dccfef6a99@users.sourceforge.net> Sender: kernel-janitors-owner@vger.kernel.org To: xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org, =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , David Vrabel , Boris Ostrovsky Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall List-Id: linux-scsi@vger.kernel.org From: Markus Elfring Date: Sat, 16 Jul 2016 21:55:01 +0200 Pass the constant "FAILED" in a function call directly instead of using an intialisation for a local variable. Signed-off-by: Markus Elfring --- drivers/xen/xen-scsiback.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen-scsiback.c index 7612bc9..ec5546c 100644 --- a/drivers/xen/xen-scsiback.c +++ b/drivers/xen/xen-scsiback.c @@ -601,7 +601,7 @@ static void scsiback_device_action(struct vscsibk_pend *pending_req, struct se_cmd *se_cmd = &pending_req->se_cmd; struct scsiback_tmr *tmr; u64 unpacked_lun = pending_req->v2p->lun; - int rc, err = FAILED; + int rc, err; tmr = kzalloc(sizeof(struct scsiback_tmr), GFP_KERNEL); if (!tmr) { @@ -629,7 +629,7 @@ static void scsiback_device_action(struct vscsibk_pend *pending_req, free_tmr: kfree(tmr); do_resp: - scsiback_do_resp_with_sense(NULL, err, 0, pending_req); + scsiback_do_resp_with_sense(NULL, FAILED, 0, pending_req); } /* -- 2.9.1