Re: [PATCH] scsi: mpi3mr: suppress command reply debug prints

[Damien Le Moal <damien.lemoal@opensource.wdc.com>]

On 11/9/22 12:12, Shin'ichiro Kawasaki wrote:
> After it receives command reply, mpi3mr driver checks command result. If
> the result is not zero, it prints out command information. This debug
> information is confusing since they are printed even when the non-zero
> result is expected. "Power-on or device reset occurred" is printed for
> Test Unit Ready command at drive detection. Inquiry failure for
> unsupported VPD page header is also printed. They are harmless but look
> like failures.
> 
> To avoid the confusion, print the command reply debug information only
> when the module parameter logging_level has value MPI3_DEBUG_REPLY=128,
> in same manner as mpt3sas driver.
> 
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> ---
>  drivers/scsi/mpi3mr/mpi3mr_os.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c
> index f77ee4051b00..2b95d1d375f2 100644
> --- a/drivers/scsi/mpi3mr/mpi3mr_os.c
> +++ b/drivers/scsi/mpi3mr/mpi3mr_os.c
> @@ -3265,7 +3265,8 @@ void mpi3mr_process_op_reply_desc(struct mpi3mr_ioc *mrioc,
>  	}
>  
>  	if (scmd->result != (DID_OK << 16) && (scmd->cmnd[0] != ATA_12) &&
> -	    (scmd->cmnd[0] != ATA_16)) {
> +	    (scmd->cmnd[0] != ATA_16) &&
> +	    mrioc->logging_level & MPI3_DEBUG_REPLY) {
>  		ioc_info(mrioc, "%s :scmd->result 0x%x\n", __func__,
>  		    scmd->result);
>  		scsi_print_command(scmd);

Looks OK.

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

-- 
Damien Le Moal
Western Digital Research