From: Bart Van Assche <bvanassche@acm.org>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Kai Mäkisara" <Kai.Makisara@kolumbus.fi>
Cc: linux-scsi@vger.kernel.org, Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Peter Wang <peter.wang@mediatek.com>,
Bean Huo <beanhuo@micron.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"Bao D. Nguyen" <quic_nguyenb@quicinc.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 2/8] scsi: Make use of bus callbacks
Date: Fri, 19 Dec 2025 10:18:29 -0800 [thread overview]
Message-ID: <e49c1ea8-bc13-4881-bc6b-2e1a08b1184f@acm.org> (raw)
In-Reply-To: <a54e363a3fd2054fb924afd7df44bca7f444b5f1.1766133330.git.u.kleine-koenig@baylibre.com>
On 12/19/25 1:25 AM, Uwe Kleine-König wrote:
> +static int scsi_bus_probe(struct device *dev)
> +{
> + struct scsi_device *sdp = to_scsi_device(dev);
> + struct scsi_driver *drv = to_scsi_driver(dev->driver);
> +
> + if (drv->probe)
> + return drv->probe(sdp);
> + else
> + return 0;
> +}
If this series has to be reposted, please leave out the "else" statement
from the above function. It is uncommon in Linux kernel code to have an
"else" statement after a "return" statement.
Thanks,
Bart.
next prev parent reply other threads:[~2025-12-19 18:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 9:25 [PATCH v2 0/8] scsi: Make use of bus callbacks Uwe Kleine-König
2025-12-19 9:25 ` [PATCH v2 1/8] scsi: Pass a struct scsi_driver to scsi_{,un}register_driver() Uwe Kleine-König
2025-12-19 9:25 ` [PATCH v2 2/8] scsi: Make use of bus callbacks Uwe Kleine-König
2025-12-19 18:18 ` Bart Van Assche [this message]
2025-12-22 8:28 ` Peter Wang (王信友)
2025-12-19 9:25 ` [PATCH v2 3/8] scsi: ch: Convert to scsi bus methods Uwe Kleine-König
2025-12-19 9:25 ` [PATCH v2 4/8] scsi: sd: " Uwe Kleine-König
2025-12-19 9:25 ` [PATCH v2 5/8] scsi: ses: " Uwe Kleine-König
2025-12-19 9:25 ` [PATCH v2 6/8] scsi: sr: " Uwe Kleine-König
2025-12-19 9:25 ` [PATCH v2 7/8] scsi: st: " Uwe Kleine-König
2025-12-19 9:25 ` [PATCH v2 8/8] scsi: ufs: " Uwe Kleine-König
2025-12-19 18:16 ` [PATCH v2 0/8] scsi: Make use of bus callbacks Bart Van Assche
2026-01-12 2:34 ` Martin K. Petersen
2026-01-17 4:36 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e49c1ea8-bc13-4881-bc6b-2e1a08b1184f@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=Kai.Makisara@kolumbus.fi \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
--cc=quic_nguyenb@quicinc.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox