From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Hunter Subject: Re: [PATCH RFC] scsi: ufs: Disable blk-mq for now Date: Thu, 13 Sep 2018 15:15:39 +0300 Message-ID: References: <20180913112848.7807-1-adrian.hunter@intel.com> <20180913120459.GA4965@ming.t460p> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180913120459.GA4965@ming.t460p> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Ming Lei Cc: "Martin K . Petersen" , "James E . J . Bottomley" , Jens Axboe , Christoph Hellwig , Johannes Thumshirn , Bart Van Assche , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Stanislav Nijnikov , Evan Green , Vinayak Holikatti , Janek Kotas , Vivek Gautam , Asutosh Das , Subhash Jadavani , Sayali Lokhande , Li Wei , Bjorn Andersson , Jaegeuk Kim List-Id: linux-scsi@vger.kernel.org On 13/09/18 15:05, Ming Lei wrote: > On Thu, Sep 13, 2018 at 02:28:48PM +0300, Adrian Hunter wrote: >> blk-mq does not support runtime pm, so disable blk-mq support for now. > > So could you describe a bit what the issue you are trying to fix? UFS is a low-power solution, so we must be able to runtime suspend. > > This is host level runtime PM you are trying to address, and if blk-mq > runtime isn't enabled, I guess the host won't be runtime suspended at all > because some of its descendant are always active. > > So seems we need to do nothing for preventing the host controller from > entering runtime suspend. We don't want to prevent the host controller from runtime suspending, quite the opposite.