From: Bart Van Assche <bvanassche@acm.org>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org
Cc: Christoph Hellwig <hch@lst.de>,
Coelho@web.codeaurora.org, Luciano <luciano.coelho@intel.com>,
Saarinen@web.codeaurora.org, Jani <jani.saarinen@intel.com>
Subject: Re: [PATCH] scsi: sd: Move sd_read_cpr() out of the q->limits_lock region
Date: Thu, 1 Aug 2024 09:07:18 -0700 [thread overview]
Message-ID: <e6641f7b-7353-4cd5-95a4-14c794a495c5@acm.org> (raw)
In-Reply-To: <20240801054234.540532-1-shinichiro.kawasaki@wdc.com>
On 7/31/24 10:42 PM, Shin'ichiro Kawasaki wrote:
> To avoid the WARN, move the sd_read_cpr() call in sd_revalidate_disk()
> after the queue_limits_commit_update() call. In other words, move the
> sd_read_cpr() call out of the q->limits_lock region.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
prev parent reply other threads:[~2024-08-01 16:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 5:42 [PATCH] scsi: sd: Move sd_read_cpr() out of the q->limits_lock region Shin'ichiro Kawasaki
2024-08-01 5:49 ` Coelho, Luciano
2024-08-01 7:09 ` Damien Le Moal
2024-08-01 14:20 ` Christoph Hellwig
2024-08-01 16:07 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6641f7b-7353-4cd5-95a4-14c794a495c5@acm.org \
--to=bvanassche@acm.org \
--cc=Coelho@web.codeaurora.org \
--cc=Saarinen@web.codeaurora.org \
--cc=hch@lst.de \
--cc=jani.saarinen@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox