From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3875E3EBF34; Thu, 26 Feb 2026 06:40:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772088010; cv=none; b=R6+4H0kQfSht85AfMZXVxGQHMeMgzppXmHS9hkMN9ThT9nFB0HpyDOnbIPbOVnjpPPps/xHxfo/R4p3Es3A9+knlhVzGzQE8D1t/R7bw2Lb3TSagdmEmGoZUkCjT0xyNk+oK8yyUtjnlwO+WR6FlKBoucjj4CF0UXTk4Rh2dQ/Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772088010; c=relaxed/simple; bh=d2TqwPVvHKCmEq++rTnFIWmWbeCT68F7PsKl69B+akQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pceWAebsfm/kw4DHGaIBE/hyw0MCUP5GVo13iiacysK2f48xCLKCGcmLTbFc1NPnBIbqsx5u04kSbxWkO15L271HL/r6r8siTW7gWb00XflbkO6Qe6l8gIRCp23MzyHWmkYfY8u5XqxGSa9DnlbdDzBF/KBrVZ8DneOiLwkKgrg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kFu8fs+J; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kFu8fs+J" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59D1EC19422; Thu, 26 Feb 2026 06:40:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772088009; bh=d2TqwPVvHKCmEq++rTnFIWmWbeCT68F7PsKl69B+akQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=kFu8fs+JTkCyY4QwTnzm5h2WDwNoG04WAGQ75jXTioKKaEAJwYi6b1oUQsKFdpeMp y+CvHys1zHoSzzRCocKTl6VVx7ep1taM/QNldf07W8scBZUYBxI2KUtdAsvLnoKXAc 6gfwxOfy4HSnMf2+pn7QofDDDHbkABUmL2+mFEuqeMTylYhwmUF+z07QAOfVCy8/mC 1bJw7Uhf/QZTvfOTx3aSh1KDU+rzCKBdv6IGKBWvmdu0C482ER8qbiiLxoj6TiHfnp xKLzXyk8mGnGooj/fUXqxVNmCpq+yMMbYL8LfaRltAL7UG7y8QCa0zMCMeqf7437n1 NfXCMbnnGwwgw== Message-ID: Date: Thu, 26 Feb 2026 07:40:04 +0100 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 3/4] ufs: host: Add ICE clock scaling during UFS clock changes To: Abhinaba Rakshit Cc: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Neeraj Soni , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org References: <20260219-enable-ufs-ice-clock-scaling-v6-0-0c5245117d45@oss.qualcomm.com> <20260219-enable-ufs-ice-clock-scaling-v6-3-0c5245117d45@oss.qualcomm.com> <784d5711-3f3a-48af-ab1b-9a8834249445@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 26/02/2026 07:14, Abhinaba Rakshit wrote: > On Wed, Feb 25, 2026 at 03:12:18PM +0100, Krzysztof Kozlowski wrote: >> On 25/02/2026 13:58, Abhinaba Rakshit wrote: >>> On Wed, Feb 25, 2026 at 10:00:12AM +0100, Krzysztof Kozlowski wrote: >>>> On 19/02/2026 10:39, Abhinaba Rakshit wrote: >>>>> Implement ICE (Inline Crypto Engine) clock scaling in sync with >>>>> UFS controller clock scaling. This ensures that the ICE operates at >>>>> an appropriate frequency when the UFS clocks are scaled up or down, >>>>> improving performance and maintaining stability for crypto operations. >>>>> >>>>> Incase of OPP scaling is not supported by ICE, ensure to not prevent >>>>> devfreq for UFS, as ICE OPP-table is optional. >>>>> >>>>> Acked-by: Manivannan Sadhasivam >>>>> Signed-off-by: Abhinaba Rakshit >>>>> --- >>>>> drivers/ufs/host/ufs-qcom.c | 21 ++++++++++++++++++++- >>>> >>>> >>>> SCSI/UFS is not respecting subsystem boundaries, thus you must not >>>> combine multiple subsystem when targeting UFS. >>>> >>>> Please split your patches. >>> >>> Sorry, if I fail to understand the context here. >>> This patch-series is already split into 4 patches based on the subsystem. >> >> s/patches/patchset/ >> Please split the patchset to not combine independent patches targeting >> different subsystem into one patchset. > > In this series, the UFS subsystem patch depends on the new ICE clock-scaling > API introduced in the crypto/ICE patch. Without that ICE change, the UFS > driver cannot call the scaling helper, so the UFS subsystem patch cannot > be applied *independently*. What? Where is this explained in the cover letter? Where is merging dependencies/order mentioned? > > Given this dependency, splitting the series into separate, standalone > patchsets would break bisectability and lead to build/runtime failures > if they are not merged together. > > Please let me know what is the preferred approach in such instance. > > Abhinaba Rakshit Best regards, Krzysztof