Re: [PATCH 3/6] lpfc: fix inlining of lpfc_sli4_cleanup_poll_list()

Ewan D. Milne
2019-11-12T18:31:42Z

On Mon, 2019-11-11 at 15:03 -0800, James Smart wrote:
> Compilation can fail due to having an inline function
> reference where the function body is not present.
>
> Fix by removing the inline tag.
>
> Fixes: 93a4d6f40198 ("scsi: lpfc: Add registration for CPU Offline/Online events")
>
> Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
> Signed-off-by: James Smart <jsmart2021@gmail.com>
> ---
> patch is in the 12.6.0.1 set which is in 5.5/scsi-queue
> ---
> drivers/scsi/lpfc/lpfc_crtn.h | 2 +-
> drivers/scsi/lpfc/lpfc_sli.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_crtn.h b/drivers/scsi/lpfc/lpfc_crtn.h
> index d91aa5330306..ee353c84a097 100644
> --- a/drivers/scsi/lpfc/lpfc_crtn.h
> +++ b/drivers/scsi/lpfc/lpfc_crtn.h
> @@ -215,7 +215,7 @@ irqreturn_t lpfc_sli_fp_intr_handler(int, void *);
> irqreturn_t lpfc_sli4_intr_handler(int, void *);
> irqreturn_t lpfc_sli4_hba_intr_handler(int, void *);
>
> -inline void lpfc_sli4_cleanup_poll_list(struct lpfc_hba *phba);
> +void lpfc_sli4_cleanup_poll_list(struct lpfc_hba *phba);
> int lpfc_sli4_poll_eq(struct lpfc_queue *q, uint8_t path);
> void lpfc_sli4_poll_hbtimer(struct timer_list *t);
> void lpfc_sli4_start_polling(struct lpfc_queue *q);
> diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
> index fad890cea21a..6d82ad9380db 100644
> --- a/drivers/scsi/lpfc/lpfc_sli.c
> +++ b/drivers/scsi/lpfc/lpfc_sli.c
> @@ -14466,7 +14466,7 @@ static inline void lpfc_sli4_remove_from_poll_list(struct lpfc_queue *eq)
> del_timer_sync(&phba->cpuhp_poll_timer);
> }
>
> -inline void lpfc_sli4_cleanup_poll_list(struct lpfc_hba *phba)
> +void lpfc_sli4_cleanup_poll_list(struct lpfc_hba *phba)
> {
> struct lpfc_queue *eq, *next;
>

Reviewed-by: Ewan D. Milne <emilne@redhat.com>