From: Martin Wilck <mwilck@suse.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Ming Lei <ming.lei@redhat.com>,
Bart Van Assche <Bart.VanAssche@sandisk.com>,
James Bottomley <jejb@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v2 3/3] scsi: simplify scsi_stop_queue()
Date: Wed, 07 Jun 2023 11:36:00 +0200 [thread overview]
Message-ID: <e982c95ad7ee29f80e8c0ba88f0cece837e344b9.camel@suse.com> (raw)
In-Reply-To: <c0563161eb613f9500e6a1cccdcff6fc64efffad.camel@suse.com>
On Wed, 2023-06-07 at 11:26 +0200, Martin Wilck wrote:
> On Wed, 2023-06-07 at 07:27 +0200, Christoph Hellwig wrote:
> >
> > 3) remove scsi_stop_queue and open code it in the two callers,
> > one
> > of which currently wants nowait semantics, and one that
> > doesn't.
> ok
Hm, scsi_stop_queue() pairs with scsi_start_queue(), do we really want
to open-code it?
Martin
next prev parent reply other threads:[~2023-06-07 9:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 19:38 [PATCH v2 0/3] scsi: fixes for targets with many LUNs mwilck
2023-06-06 19:38 ` [PATCH v2 1/3] bsg: increase number of devices mwilck
2023-06-07 5:10 ` Christoph Hellwig
2023-06-06 19:38 ` [PATCH v2 2/3] scsi: sg: " mwilck
2023-06-07 5:10 ` Christoph Hellwig
2023-06-06 19:38 ` [PATCH v2 3/3] scsi: simplify scsi_stop_queue() mwilck
2023-06-07 5:27 ` Christoph Hellwig
2023-06-07 9:26 ` Martin Wilck
2023-06-07 9:36 ` Martin Wilck [this message]
2023-06-07 13:34 ` Christoph Hellwig
2023-06-07 14:05 ` Bart Van Assche
2023-06-07 14:08 ` Christoph Hellwig
2023-06-07 15:38 ` Martin Wilck
2023-06-07 16:39 ` Bart Van Assche
2023-06-07 17:56 ` Martin Wilck
2023-06-06 20:33 ` [PATCH v2 0/3] scsi: fixes for targets with many LUNs Bart Van Assche
2023-06-07 1:20 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e982c95ad7ee29f80e8c0ba88f0cece837e344b9.camel@suse.com \
--to=mwilck@suse.com \
--cc=Bart.VanAssche@sandisk.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).