Re: [PATCH v2] scsi: target: core: check SR field in REPORT LUNS

Martin K. Petersen
2021-01-27T05:37:34Z

Dmitry,

> + switch (sr) {
> + case SCSI_SELECT_WELLKNOWN:
> + case SCSI_SELECT_ADMINISTRATIVE:
> + case SCSI_SELECT_SUBSIDIARY:
> + /* report empty lun list */
> + goto out;

I'm a bit concerned about things inadvertently breaking if we return an
empty list for the well known LUNs.

--
Martin K. Petersen Oracle Linux Engineering