Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: <alim.akhtar@samsung.com>, <avri.altman@wdc.com>,
	<bvanassche@acm.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
	<conor+dt@kernel.org>, <mani@kernel.org>,
	<James.Bottomley@hansenpartnership.com>,
	<martin.petersen@oracle.com>, <linux-scsi@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH V5 1/4] ufs: dt-bindings: Document gear and rate limit properties
Date: Fri, 12 Sep 2025 21:14:04 +0530	[thread overview]
Message-ID: <ea81a84c-738e-4e70-a0d4-e5f6d4b1064f@quicinc.com> (raw)
In-Reply-To: <2360f9f8-470d-46dc-be9e-660bb1580428@quicinc.com>



On 09-Sep-25 8:28 PM, Ram Kumar Dwivedi wrote:
> 
> 
> On 03-Sep-25 12:14 PM, Krzysztof Kozlowski wrote:
>> On Tue, Sep 02, 2025 at 10:18:57PM +0530, Ram Kumar Dwivedi wrote:
>>> Add optional "limit-hs-gear" and "limit-rate" properties to the
>>> UFS controller common binding. These properties allow limiting
>>> the maximum HS gear and rate.
>>>
>>> This is useful in cases where the customer board may have signal
>>> integrity, clock configuration or layout issues that prevent reliable
>>> operation at higher gears. Such limitations are especially critical in
>>> those platforms, where stability is prioritized over peak performance.
>>>
>>> Signed-off-by: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com>
>>> ---
>>>  .../devicetree/bindings/ufs/ufs-common.yaml      | 16 ++++++++++++++++
>>>  1 file changed, 16 insertions(+)
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Hi Krzysztof,
> 
> Alim has recommended renaming the "limit-rate" property to "limit-gear-rate".
> Please let me know if you have any concerns.
> 
> Also, may I retain your "Reviewed-by" tag in the next patchset?
>
Hi Krzysztof,

Just a friendly reminder,
Would appreciate your feedback when you have time.

Thanks,
Ram.> Thanks,
> Ram.> 
>> Best regards,
>> Krzysztof
>>
> 


  reply	other threads:[~2025-09-12 15:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20250902164927epcas5p459352c28c0d5c5a4c04bd88345a049f0@epcas5p4.samsung.com>
2025-09-02 16:48 ` [PATCH V5 0/4] Add DT-based gear and rate limiting support Ram Kumar Dwivedi
2025-09-02 16:48   ` [PATCH V5 1/4] ufs: dt-bindings: Document gear and rate limit properties Ram Kumar Dwivedi
2025-09-03  6:44     ` Krzysztof Kozlowski
2025-09-09 14:58       ` Ram Kumar Dwivedi
2025-09-12 15:44         ` Ram Kumar Dwivedi [this message]
2025-09-17 14:09           ` Ram Kumar Dwivedi
2025-09-02 16:48   ` [PATCH V5 2/4] ufs: ufs-qcom: Remove redundant re-assignment to hs_rate Ram Kumar Dwivedi
2025-09-03  4:53     ` Alim Akhtar
2025-09-17 14:29       ` Ram Kumar Dwivedi
2025-09-02 16:48   ` [PATCH V5 3/4] ufs: pltfrm: Allow limiting HS gear and rate via DT Ram Kumar Dwivedi
2025-09-03  4:28     ` Alim Akhtar
2025-09-17 14:14       ` Ram Kumar Dwivedi
2025-09-02 16:49   ` [PATCH V5 4/4] ufs: ufs-qcom: Add support for limiting HS gear and rate Ram Kumar Dwivedi
2025-09-03  4:48   ` [PATCH V5 0/4] Add DT-based gear and rate limiting support Alim Akhtar
2025-09-17 14:19     ` Ram Kumar Dwivedi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea81a84c-738e-4e70-a0d4-e5f6d4b1064f@quicinc.com \
    --to=quic_rdwivedi@quicinc.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=bvanassche@acm.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox