From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DB01C433EF for ; Thu, 3 Mar 2022 16:29:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235028AbiCCQaU (ORCPT ); Thu, 3 Mar 2022 11:30:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235021AbiCCQaL (ORCPT ); Thu, 3 Mar 2022 11:30:11 -0500 Received: from esa4.hgst.iphmx.com (esa4.hgst.iphmx.com [216.71.154.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E34419CCD5 for ; Thu, 3 Mar 2022 08:29:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1646324965; x=1677860965; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=VAgz2vhs3PqyekpxFO87UXkBgw8sk7MSyxO2iB9CLC8=; b=kRtzBb0XF0IyDr+RsMKHTfXMchnXfwxk1FWmx2O7VOiKrKQqIMvP/qct vgk0JDJGoNxf07gvgHezya2eViKTV52UaX+oXD1O873lGAGbzFiqmFDN8 wRg3j+uc/GeGnfuwepQmQpcQzJJEWVsZy09usmpkL8ouv1LwG/DHpbuXr Kod6U7gOEpKaWcPJTiC4IdzyeCXtEMPqHqBn/AEWoyD0sSpRmV29JoY0w 9M0T1udo6GKYzxWMq2o6hCc+hlwbhqEOpfUT3C6wYIL8Nelah8MU6lUbd JpSJce9zjYc6DOEQKoqIhme8nYpNHi7XCywxLUBhYVHjUSISYGBm0wzSI Q==; X-IronPort-AV: E=Sophos;i="5.90,151,1643644800"; d="scan'208";a="193333116" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 04 Mar 2022 00:29:24 +0800 IronPort-SDR: kthoxhfbAGTaO3tSucRgG+lyP94av5N9d20kYVMHorkRg7RTAav5QRKy8rEj/+6J+VdWCjmC26 +Sx/+zpsTESHmmeGi3pGu7L2JsW64Ealp2HWOQpg76q/HMh1l777K+li2BOcfclJypRqmv/XWC P8y6KG0S63p/KJQOovs306vto8H8bp//pGw31TxxbqNCIdX9NzcxLhKmMtGf5BwUXh9Wz8h8cA cmDCYJsWuMeynjq5icqObTmMQGp2HAeHoxm88bp1b/0jn6bfWX1feL0q4wX3lhjLrWyByuy7rQ KTT85rB/p7fvFpubNpf/59UZ Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2022 08:01:48 -0800 IronPort-SDR: Ug12Gn6scjtDLXiMYJraBRJyS9pldkiuYmniDpdqOCxprgGMNoHo55eWwaJ2HDy9/gH65kiCCJ yQEjnK+0BP9DWyb9wmj/yEzYwOSFXBUfQqMl2R1xV9xlQ6tS3VTmfT0xuqa+1NtcDTw87JGL2F tP0hfoS0RncbUO84K7hdeUR4fsiZTI0xmHvHA9wlVYUR/ekCsfYTZnrkGoCSlA6L4EVVm/+zGx LWAWtrByBpgEFZrl4Y8YXtuSEIWG2hadmhdWEBSmyjOUmn8lHmJwt2uFoCKKg2saG3YGG3/kkG BVo= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2022 08:29:24 -0800 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4K8bzR6Czkz1SVp4 for ; Thu, 3 Mar 2022 08:29:23 -0800 (PST) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1646324963; x=1648916964; bh=VAgz2vhs3PqyekpxFO87UXkBgw8sk7MSyxO 2iB9CLC8=; b=hdiVjcp3NrPjLgy9kUQlL5AVY2bVDNV3Ql79WPIPyS/HUg+KM4F AS4K+VG7nQxbL6Cc35yMIDFUXg2WGeFv9mnRhi5gkd4mF14EPTtV2Pdvx6QlkvPt 9zNxoh3PSNpTHNdlvcMEHv8eR63ry+wCKZ5CMPNZzrnssm1gHr4R+xRyniuh9p17 UQD8N8GD6vTDzfcLXcdaAlaXvU4VxxOUu030PgX3DrY/o71Lb+ZE6ZFLfRTqfgm6 Nyx3t+3IVinYmIk5iEjz+kh6WXZyRp9ZGJLAt152JpXX2F0PlGt4kMTt0V9T+uch SfqeYuvg+dz1yxigBQLVcDMhLy/Tffdbaiw== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id gJ2R3vPWClG1 for ; Thu, 3 Mar 2022 08:29:23 -0800 (PST) Received: from [10.225.33.67] (unknown [10.225.33.67]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4K8bzM55c7z1Rvlx; Thu, 3 Mar 2022 08:29:19 -0800 (PST) Message-ID: Date: Thu, 3 Mar 2022 18:29:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 0/4] scsi: libsas and users: Factor out internal abort code Content-Language: en-US To: John Garry , jejb@linux.ibm.com, martin.petersen@oracle.com, jinpu.wang@cloud.ionos.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Ajish.Koshy@microchip.com, linuxarm@huawei.com, Viswas.G@microchip.com, hch@lst.de, liuqi115@huawei.com, chenxiang66@hisilicon.com References: <1646309930-138960-1-git-send-email-john.garry@huawei.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <1646309930-138960-1-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 2022/03/03 14:18, John Garry wrote: > This is a follow-on from the series to factor out the TMF code shared > between libsas LLDDs. > > The hisi_sas and pm8001 have an internal abort feature to abort pending > commands in the host controller, prior to being sent to the target. The > driver support implementation is naturally quite similar, so factor it > out. > > Again, testing and review would be appreciated. John, Traveling this week so testing will be difficult. I will try this first thing Monday next week. > > This is based on mkp-scsi 5.18 staging queue @ commit f2ddbbea7780 > > John Garry (4): > scsi: libsas: Add sas_execute_internal_abort_single() > scsi: libsas: Add sas_execute_internal_abort_dev() > scsi: pm8001: Use libsas internal abort support > scsi: hisi_sas: Use libsas internal abort support > > drivers/scsi/hisi_sas/hisi_sas.h | 8 +- > drivers/scsi/hisi_sas/hisi_sas_main.c | 453 +++++++++---------------- > drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 11 +- > drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 18 +- > drivers/scsi/libsas/sas_scsi_host.c | 89 +++++ > drivers/scsi/pm8001/pm8001_hwi.c | 27 +- > drivers/scsi/pm8001/pm8001_hwi.h | 5 - > drivers/scsi/pm8001/pm8001_sas.c | 186 ++++------ > drivers/scsi/pm8001/pm8001_sas.h | 6 +- > drivers/scsi/pm8001/pm80xx_hwi.h | 5 - > include/scsi/libsas.h | 24 ++ > include/scsi/sas.h | 2 + > 12 files changed, 368 insertions(+), 466 deletions(-) > -- Damien Le Moal Western Digital Research