From: John Garry <john.g.garry@oracle.com>
To: Niklas Cassel <cassel@kernel.org>,
Jason Yan <yanaijie@huawei.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Damien Le Moal <dlemoal@kernel.org>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2 03/10] scsi: libsas: Add dev_parent_is_expander() helper
Date: Fri, 15 Aug 2025 09:42:33 +0100 [thread overview]
Message-ID: <ebaa25b9-9abc-4ab3-bba7-7a375334d4be@oracle.com> (raw)
In-Reply-To: <0823c04c-4d52-4814-88e6-a594c19a6259@oracle.com>
On 15/08/2025 08:07, John Garry wrote:
> On 14/08/2025 18:32, Niklas Cassel wrote:
>> Many libsas drivers check if the parent of the device is an expander.
>> Create a helper that the libsas drivers will use in follow up commits.
>>
>> Suggested-by: Damien Le Moal<dlemoal@kernel.org>
>> Signed-off-by: Niklas Cassel<cassel@kernel.org>
>
> Reviewed-by: John Garry <john.g.garry@oracle.com>
>
BTW, I was going to suggest to make dev_is_expander() to accept a
domain_device * (like dev_parent_is_expander()). That would make the
code more concise. However there are a couple of callsites which pass
phy->attached_dev_type, and not dev->dev_type.
next prev parent reply other threads:[~2025-08-15 8:42 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 17:32 [PATCH v2 00/10] scsi: pm80xx: Fix expander support Niklas Cassel
2025-08-14 17:32 ` [PATCH v2 01/10] scsi: pm80xx: Restore support for expanders Niklas Cassel
2025-08-15 2:30 ` Damien Le Moal
2025-08-14 17:32 ` [PATCH v2 02/10] scsi: pm80xx: Fix array-index-out-of-of-bounds on rmmod Niklas Cassel
2025-08-15 2:30 ` Damien Le Moal
2025-08-14 17:32 ` [PATCH v2 03/10] scsi: libsas: Add dev_parent_is_expander() helper Niklas Cassel
2025-08-15 2:31 ` Damien Le Moal
2025-08-15 7:07 ` John Garry
2025-08-15 8:42 ` John Garry [this message]
2025-08-18 3:07 ` Jason Yan
2025-08-14 17:32 ` [PATCH v2 04/10] scsi: hisi_sas: Use " Niklas Cassel
2025-08-15 2:31 ` Damien Le Moal
2025-08-15 8:32 ` John Garry
2025-08-14 17:32 ` [PATCH v2 05/10] scsi: isci: " Niklas Cassel
2025-08-15 2:32 ` Damien Le Moal
2025-08-15 8:33 ` John Garry
2025-08-14 17:32 ` [PATCH v2 06/10] scsi: mvsas: " Niklas Cassel
2025-08-15 2:32 ` Damien Le Moal
2025-08-15 8:33 ` John Garry
2025-08-14 17:32 ` [PATCH v2 07/10] scsi: pm80xx: " Niklas Cassel
2025-08-15 2:33 ` Damien Le Moal
2025-08-15 8:34 ` John Garry
2025-08-15 16:39 ` Igor Pylypiv
2025-08-18 7:45 ` Jinpu Wang
2025-08-14 17:32 ` [PATCH v2 08/10] scsi: pm80xx: Add helper function to get the local phy id Niklas Cassel
2025-08-15 2:34 ` Damien Le Moal
2025-08-14 17:32 ` [PATCH v2 09/10] scsi: pm80xx: Fix pm8001_abort_task() for chip_8006 when using an expander Niklas Cassel
2025-08-15 2:35 ` Damien Le Moal
2025-08-14 17:32 ` [PATCH v2 10/10] scsi: pm80xx: Use pm80xx_get_local_phy_id() to access phy array Niklas Cassel
2025-08-15 2:36 ` Damien Le Moal
2025-08-15 16:40 ` Igor Pylypiv
2025-08-18 7:46 ` Jinpu Wang
2025-08-19 2:10 ` [PATCH v2 00/10] scsi: pm80xx: Fix expander support Martin K. Petersen
2025-08-26 2:33 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebaa25b9-9abc-4ab3-bba7-7a375334d4be@oracle.com \
--to=john.g.garry@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).