From: Bean Huo <huobean@gmail.com>
To: Bart Van Assche <bvanassche@acm.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-scsi@vger.kernel.org,
Adrian Hunter <adrian.hunter@intel.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Bean Huo <beanhuo@micron.com>, Avri Altman <avri.altman@wdc.com>,
Jinyoung Choi <j-young.choi@samsung.com>,
Peter Wang <peter.wang@mediatek.com>,
Daniil Lunev <dlunev@chromium.org>,
Stanley Chu <stanley.chu@mediatek.com>,
Asutosh Das <quic_asutoshd@quicinc.com>,
Ziqi Chen <quic_ziqichen@quicinc.com>,
Arthur Simchaev <arthur.simchaev@wdc.com>,
Adrien Thierry <athierry@redhat.com>,
Can Guo <quic_cang@quicinc.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Eric Biggers <ebiggers@google.com>,
Keoseong Park <keosung.park@samsung.com>
Subject: Re: [PATCH v4 5/5] scsi: ufs: Ungate the clock synchronously
Date: Tue, 30 May 2023 13:10:05 +0200 [thread overview]
Message-ID: <ebfa75c01d0f565d82b78d68417da4abfd0985cf.camel@gmail.com> (raw)
In-Reply-To: <20230529202640.11883-6-bvanassche@acm.org>
On Mon, 2023-05-29 at 13:26 -0700, Bart Van Assche wrote:
> Ungating the clock asynchronously causes ufshcd_queuecommand() to
> return
> SCSI_MLQUEUE_HOST_BUSY and hence causes commands to be requeued.
> This is
> suboptimal. Allow ufshcd_queuecommand() to sleep such that clock
> ungating
> does not trigger command requeuing. Remove the
> ufshcd_scsi_block_requests()
> and ufshcd_scsi_unblock_requests() calls because these are no longer
> needed. The flush_work(&hba->clk_gating.ungate_work) call is
> sufficient to
> make the SCSI core wait for clock ungating to complete.
>
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Bean Huo <beanhuo@micron.com>
next prev parent reply other threads:[~2023-05-30 11:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 20:26 [PATCH v4 0/5] ufs: Do not requeue while ungating the clock Bart Van Assche
2023-05-29 20:26 ` [PATCH v4 1/5] scsi: core: Rework scsi_host_block() Bart Van Assche
2023-05-29 20:26 ` [PATCH v4 2/5] scsi: core: Support setting BLK_MQ_F_BLOCKING Bart Van Assche
2023-05-29 20:26 ` [PATCH v4 3/5] scsi: ufs: Conditionally enable the BLK_MQ_F_BLOCKING flag Bart Van Assche
2023-05-30 9:52 ` Bean Huo
2023-05-29 20:26 ` [PATCH v4 4/5] scsi: ufs: Declare ufshcd_{hold,release}() once Bart Van Assche
2023-05-30 9:48 ` Adrian Hunter
2023-05-31 7:59 ` Keoseong Park
2023-05-29 20:26 ` [PATCH v4 5/5] scsi: ufs: Ungate the clock synchronously Bart Van Assche
2023-05-30 11:10 ` Bean Huo [this message]
2023-05-30 17:39 ` Bao D. Nguyen
2023-05-31 15:45 ` [PATCH v4 0/5] ufs: Do not requeue while ungating the clock Martin K. Petersen
2023-06-08 1:42 ` Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2023-05-29 20:21 [PATCH] scsi: stex: Fix gcc 13 warnings Bart Van Assche
2023-05-29 20:21 ` [PATCH v4 5/5] scsi: ufs: Ungate the clock synchronously Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebfa75c01d0f565d82b78d68417da4abfd0985cf.camel@gmail.com \
--to=huobean@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=arthur.simchaev@wdc.com \
--cc=athierry@redhat.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=dlunev@chromium.org \
--cc=ebiggers@google.com \
--cc=j-young.choi@samsung.com \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=keosung.park@samsung.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=peter.wang@mediatek.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_ziqichen@quicinc.com \
--cc=stanley.chu@mediatek.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox