From: Bart Van Assche <bvanassche@acm.org>
To: Stanley Chu <chu.stanley@gmail.com>
Cc: Po-Wen Kao <powen.kao@mediatek.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
wsd_upstream@mediatek.com, peter.wang@mediatek.com,
stanley.chu@mediatek.com, alice.chao@mediatek.com,
naomi.chu@mediatek.com, chun-hung.wu@mediatek.com,
cc.chou@mediatek.com, eddie.huang@mediatek.com
Subject: Re: [PATCH v2 1/3] scsi: ufs: core: Introduce mcq ops to config cqid
Date: Wed, 31 May 2023 05:48:27 -0700 [thread overview]
Message-ID: <ec9c378c-fedd-5a90-bb12-085395e0d22e@acm.org> (raw)
In-Reply-To: <CAGaU9a9TsoaUtoMX8cNmAhfBnCddRtWYEG8ACdRNJfri+sdasg@mail.gmail.com>
On 5/30/23 18:54, Stanley Chu wrote:
> In addition, some benchmark data shows that the performance can be
> improved by using fewer CQs to aggregate the interrupt handling of
> completion requests.
What has been measured? IOPS only or both IOPS and latency?
How big is the difference? A few percent or more?
For which number of SQs and which number of CQs has performance data
been measured?
Would the following work instead of introducing a new vop?
- Introduce a new capability flag, e.g. UFSHCD_CAP_SINGLE_CQ.
- Set that flag from inside ufs_mtk_init().
- Modify the UFS core driver such that the number of completion queues
depends on the UFSHCD_CAP_SINGLE_CQ flag.
> Therefore, we would like to introduce a vop to allow the host to
> configure it accordingly.
We do not accept new vops upstream without a user. Where is the
implementation of the new .config_cqid() callback?
Thanks,
Bart.
next prev parent reply other threads:[~2023-05-31 12:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 2:32 [PATCH v2 0/3] Add MCQ support for MTK platform Po-Wen Kao
2023-05-30 2:32 ` [PATCH v2 1/3] scsi: ufs: core: Introduce mcq ops to config cqid Po-Wen Kao
2023-05-30 7:20 ` AngeloGioacchino Del Regno
2023-05-30 9:42 ` Powen Kao (高伯文)
2023-05-30 23:54 ` Bart Van Assche
2023-05-31 1:54 ` Stanley Chu
2023-05-31 12:48 ` Bart Van Assche [this message]
2023-06-01 10:25 ` Powen Kao (高伯文)
2023-06-01 14:23 ` Bart Van Assche
[not found] ` <d5f239c6f104d9dd4e5493d5d06709e33f12226b.camel@mediatek.com>
2023-06-01 20:54 ` Bart Van Assche
2023-05-30 2:32 ` [PATCH v2 2/3] scsi: ufs: core: Export symbols for MTK driver module Po-Wen Kao
2023-05-31 0:00 ` Bart Van Assche
2023-05-30 2:32 ` [PATCH v2 3/3] scsi: ufs: ufs-mediatek: Add MCQ support for MTK platform Po-Wen Kao
2023-05-30 23:58 ` Bart Van Assche
2023-05-30 2:53 ` [PATCH v2 0/3] " Stanley Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec9c378c-fedd-5a90-bb12-085395e0d22e@acm.org \
--to=bvanassche@acm.org \
--cc=alice.chao@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=avri.altman@wdc.com \
--cc=cc.chou@mediatek.com \
--cc=chu.stanley@gmail.com \
--cc=chun-hung.wu@mediatek.com \
--cc=eddie.huang@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=naomi.chu@mediatek.com \
--cc=peter.wang@mediatek.com \
--cc=powen.kao@mediatek.com \
--cc=stanley.chu@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).