From: Bart Van Assche <bvanassche@acm.org>
To: Junxiao Bi <junxiao.bi@oracle.com>, linux-scsi@vger.kernel.org
Cc: martin.petersen@oracle.com, James.Bottomley@HansenPartnership.com
Subject: Re: [PATCH] scsi: fix refcount leaking for "tagset_refcnt"
Date: Fri, 27 Feb 2026 10:46:13 -0800 [thread overview]
Message-ID: <ecd223ba-aebb-4930-bd21-76a7d44f5789@acm.org> (raw)
In-Reply-To: <20260223232728.93350-1-junxiao.bi@oracle.com>
On 2/23/26 3:27 PM, Junxiao Bi wrote:
> diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
> index 7acbfcfc2172..c64ef71633d8 100644
> --- a/drivers/scsi/scsi_scan.c
> +++ b/drivers/scsi/scsi_scan.c
> @@ -361,6 +361,7 @@ static struct scsi_device *scsi_alloc_sdev(struct scsi_target *starget,
> * since we use this queue depth most of times.
> */
> if (scsi_realloc_sdev_budget_map(sdev, depth)) {
> + kref_put(&sdev->host->tagset_refcnt, scsi_mq_free_tags);
> put_device(&starget->dev);
> kfree(sdev);
> goto out;
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2026-02-27 18:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 23:27 [PATCH] scsi: fix refcount leaking for "tagset_refcnt" Junxiao Bi
2026-02-27 18:32 ` Mike Christie
2026-02-27 18:46 ` Bart Van Assche [this message]
2026-02-28 22:28 ` Martin K. Petersen
2026-03-01 2:11 ` Martin K. Petersen
2026-03-02 10:30 ` John Garry
2026-03-02 20:36 ` junxiao.bi
2026-03-03 11:06 ` John Garry
2026-03-03 16:58 ` junxiao.bi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecd223ba-aebb-4930-bd21-76a7d44f5789@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=junxiao.bi@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox