From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 474E4C2D0EB for ; Mon, 30 Mar 2020 08:50:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1E0DB20732 for ; Mon, 30 Mar 2020 08:50:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729583AbgC3IuM (ORCPT ); Mon, 30 Mar 2020 04:50:12 -0400 Received: from mail.archive.org ([207.241.224.6]:47652 "EHLO mail.archive.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728759AbgC3IuM (ORCPT ); Mon, 30 Mar 2020 04:50:12 -0400 Received: from mail.archive.org (localhost [127.0.0.1]) by mail.archive.org (Postfix) with ESMTP id 001B720F8A; Mon, 30 Mar 2020 08:50:11 +0000 (UTC) Received: from [0.0.0.0] (a82-161-36-93.adsl.xs4all.nl [82.161.36.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: merlijn@archive.org) by mail.archive.org (Postfix) with ESMTPSA id 8965820EF6; Mon, 30 Mar 2020 08:50:10 +0000 (UTC) Subject: Re: [PATCH] sr: Fix sr_block_release() To: Bart Van Assche , "Martin K . Petersen" , "James E . J . Bottomley" Cc: linux-scsi@vger.kernel.org, Arnd Bergmann , stable@kernel.org, simon@octiron.net References: <20200330025151.10535-1-bvanassche@acm.org> From: "Merlijn B.W. Wajer" Message-ID: Date: Mon, 30 Mar 2020 10:51:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200330025151.10535-1-bvanassche@acm.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Envelope-From: Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Hi, Oops, looks like Simon (CC) reported this earlier on too, missed that. On 30/03/2020 04:51, Bart Van Assche wrote: > This patch fixes the following two complaints: Acked-By: Merlijn Wajer Cheers, Merlijn > > [snip] > > Cc: Merlijn Wajer > Cc: Arnd Bergmann > Cc: > Fixes: 51a858817dcd ("scsi: sr: get rid of sr global mutex") > Signed-off-by: Bart Van Assche > --- > drivers/scsi/sr.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c > index 0f1a926f6341..e8b2e014770c 100644 > --- a/drivers/scsi/sr.c > +++ b/drivers/scsi/sr.c > @@ -551,10 +551,12 @@ static int sr_block_open(struct block_device *bdev, fmode_t mode) > static void sr_block_release(struct gendisk *disk, fmode_t mode) > { > struct scsi_cd *cd = scsi_cd(disk); > + > mutex_lock(&cd->lock); > cdrom_release(&cd->cdi, mode); > - scsi_cd_put(cd); > mutex_unlock(&cd->lock); > + > + scsi_cd_put(cd); > } > > #ifndef CONFIG_COMPAT >