From: Bart Van Assche <bvanassche@acm.org>
To: John Garry <john.g.garry@oracle.com>,
Qiang Ma <maqianga@uniontech.com>,
James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, axboe@kernel.dk, dwagner@suse.de,
ming.lei@redhat.com, hare@suse.de
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: Don't wait for completion of in-flight requests
Date: Tue, 26 Nov 2024 05:49:50 -0800 [thread overview]
Message-ID: <ed22e2ea-bf28-4eba-bfb1-afe9f79dc3b7@acm.org> (raw)
In-Reply-To: <7c95b86b-68a0-41f8-a09c-3cb4b06fe61a@oracle.com>
On 11/26/24 4:21 AM, John Garry wrote:
> On 26/11/2024 11:50, Qiang Ma wrote:
>> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
>> index adee6f60c966..0a2d5d9327fc 100644
>> --- a/drivers/scsi/scsi_lib.c
>> +++ b/drivers/scsi/scsi_lib.c
>> @@ -2065,7 +2065,7 @@ int scsi_mq_setup_tags(struct Scsi_Host *shost)
>> tag_set->queue_depth = shost->can_queue;
>> tag_set->cmd_size = cmd_size;
>> tag_set->numa_node = dev_to_node(shost->dma_dev);
>> - tag_set->flags = BLK_MQ_F_SHOULD_MERGE;
>> + tag_set->flags = BLK_MQ_F_SHOULD_MERGE | BLK_MQ_F_STACKING;
>
> This should not be set for all SCSI hosts. Some SCSI hosts rely on
> bf0beec0607d.
Are there any SCSI hosts for which it is safe to set this flag? To me
the above change looks like a hack that should not be merged at all. Did
I perhaps overlook something?
Thanks,
Bart.
next prev parent reply other threads:[~2024-11-26 13:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-26 11:50 [PATCH] scsi: Don't wait for completion of in-flight requests Qiang Ma
2024-11-26 12:21 ` John Garry
2024-11-26 13:49 ` Bart Van Assche [this message]
2024-11-27 13:53 ` Qiang Ma
2024-11-26 14:15 ` Ming Lei
2024-11-27 14:04 ` Qiang Ma
2024-11-27 15:20 ` Ming Lei
2024-12-03 13:21 ` Qiang Ma
2024-12-03 14:36 ` Ming Lei
2024-12-04 8:45 ` Qiang Ma
2024-12-04 10:02 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed22e2ea-bf28-4eba-bfb1-afe9f79dc3b7@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@kernel.dk \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=john.g.garry@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=maqianga@uniontech.com \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox