From: Bean Huo <huobean@gmail.com>
To: Avri Altman <Avri.Altman@wdc.com>,
"peter.wang@mediatek.com" <peter.wang@mediatek.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>
Cc: "wsd_upstream@mediatek.com" <wsd_upstream@mediatek.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"chun-hung.wu@mediatek.com" <chun-hung.wu@mediatek.com>,
"alice.chao@mediatek.com" <alice.chao@mediatek.com>,
"cc.chou@mediatek.com" <cc.chou@mediatek.com>,
"chaotian.jing@mediatek.com" <chaotian.jing@mediatek.com>,
"jiajie.hao@mediatek.com" <jiajie.hao@mediatek.com>,
"powen.kao@mediatek.com" <powen.kao@mediatek.com>,
"qilin.tan@mediatek.com" <qilin.tan@mediatek.com>,
"lin.gui@mediatek.com" <lin.gui@mediatek.com>,
"tun-yu.yu@mediatek.com" <tun-yu.yu@mediatek.com>,
"eddie.huang@mediatek.com" <eddie.huang@mediatek.com>,
"naomi.chu@mediatek.com" <naomi.chu@mediatek.com>,
"chu.stanley@gmail.com" <chu.stanley@gmail.com>,
"beanhuo@micron.com" <beanhuo@micron.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v1] ufs: core: fix deadlock when rtc update
Date: Fri, 12 Jul 2024 12:49:33 +0200 [thread overview]
Message-ID: <edbedd4e992dd0adb93adbd45a74614c4c0f626d.camel@gmail.com> (raw)
In-Reply-To: <DM6PR04MB6575B81B788F260A8C640684FCA62@DM6PR04MB6575.namprd04.prod.outlook.com>
On Fri, 2024-07-12 at 10:33 +0000, Avri Altman wrote:
> > @@ -8188,8 +8188,15 @@ static void ufshcd_rtc_work(struct
> > work_struct
> > *work)
> >
> > hba = container_of(to_delayed_work(work), struct ufs_hba,
> > ufs_rtc_update_work);
> Will returning here If (!ufshcd_is_ufs_dev_active(hba)) works?
> And remove it in the 2nd if clause?
Avri,
we need to reschedule next time work in the below code. if return,
cannot.
whatelse I missed?
kind regards,
Bean
next prev parent reply other threads:[~2024-07-12 10:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 9:43 [PATCH v1] ufs: core: fix deadlock when rtc update peter.wang
2024-07-12 9:51 ` Bean Huo
2024-07-12 10:33 ` Avri Altman
2024-07-12 10:49 ` Bean Huo [this message]
2024-07-12 12:31 ` Avri Altman
2024-07-13 20:17 ` Bean Huo
2024-07-15 6:27 ` Peter Wang (王信友)
2024-07-12 17:34 ` Bart Van Assche
2024-07-14 22:37 ` Bean Huo
2024-07-15 6:31 ` Peter Wang (王信友)
2024-07-15 6:29 ` Peter Wang (王信友)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edbedd4e992dd0adb93adbd45a74614c4c0f626d.camel@gmail.com \
--to=huobean@gmail.com \
--cc=Avri.Altman@wdc.com \
--cc=alice.chao@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=beanhuo@micron.com \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chu.stanley@gmail.com \
--cc=chun-hung.wu@mediatek.com \
--cc=eddie.huang@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=jiajie.hao@mediatek.com \
--cc=lin.gui@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=naomi.chu@mediatek.com \
--cc=peter.wang@mediatek.com \
--cc=powen.kao@mediatek.com \
--cc=qilin.tan@mediatek.com \
--cc=stable@vger.kernel.org \
--cc=tun-yu.yu@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox