Re: [PATCH 3/8] block: don't update BLK_FEAT_POLL in __blk_mq_update_nr_hw_queues

Christoph Hellwig
2025-01-07T08:21:56Z

On Tue, Jan 07, 2025 at 12:27:35PM +0530, Nilay Shroff wrote:
> As discussed in another thread with Damien, shouldn't we need to
> move bdev_can_poll() to header file?

Well, if it was needed I would have done it, otherwise the code wouldn't
compile, would it?

> We also need to use this
> function while reading sysfs attribute "io-poll", no?

This now reports polling support when the driver declared it but
later resized the number of queues to have no queues left. Which I
think is a fine tradeoff if you do that.