From: Bean Huo <huobean@gmail.com>
To: Avri Altman <avri.altman@wdc.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Manivannan Sadhasivam <manisadhasivam.linux@gmail.com>,
Bart Van Assche <bvanassche@acm.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH v3 2/2] scsi: ufs: Fix toggling of clk_gating.state when clock gating is not allowed
Date: Sun, 26 Jan 2025 22:55:22 +0100 [thread overview]
Message-ID: <f069e33f01f8489b4baa8d1e5b3db4eb055ff118.camel@gmail.com> (raw)
In-Reply-To: <20250126064521.3857557-3-avri.altman@wdc.com>
On Sun, 2025-01-26 at 08:45 +0200, Avri Altman wrote:
> } else if (!ret && on && hba->clk_gating.is_initialized) {
> scoped_guard(spinlock_irqsave, &hba->clk_gating.lock)
> hba->clk_gating.state = CLKS_ON;
> trace_ufshcd_clk_gating(dev_name(hba->dev)
Consolidating all clock-related initialization into a single function,
such as ufshcd_init_clocks(), should be considered.
next prev parent reply other threads:[~2025-01-26 21:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-26 6:45 [PATCH v3 0/2] Fixes for UFS clock gating initialization Avri Altman
2025-01-26 6:45 ` [PATCH v3 1/2] scsi: ufs: core: Ensure clk_gating.lock is used only after initialization Avri Altman
2025-01-26 19:55 ` Bean Huo
2025-01-27 9:54 ` Geert Uytterhoeven
2025-01-26 6:45 ` [PATCH v3 2/2] scsi: ufs: Fix toggling of clk_gating.state when clock gating is not allowed Avri Altman
2025-01-26 21:55 ` Bean Huo [this message]
2025-01-27 7:07 ` Avri Altman
2025-01-27 10:10 ` Geert Uytterhoeven
2025-01-27 12:00 ` Avri Altman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f069e33f01f8489b4baa8d1e5b3db4eb055ff118.camel@gmail.com \
--to=huobean@gmail.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manisadhasivam.linux@gmail.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox