From: Zijun Hu <zijun_hu@icloud.com>
To: "Uwe Kleine-König" <ukleinek@kernel.org>,
quic_zijuhu <quic_zijuhu@quicinc.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"James Bottomley" <James.Bottomley@hansenpartnership.com>,
"Thomas Weißschuh" <thomas@t-8ch.de>,
linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev,
linux-sound@vger.kernel.org, sparclinux@vger.kernel.org,
linux-block@vger.kernel.org, linux-cxl@vger.kernel.org,
linux1394-devel@lists.sourceforge.net, arm-scmi@vger.kernel.org,
linux-efi@vger.kernel.org, linux-gpio@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org, linux-hwmon@vger.kernel.org,
linux-media@vger.kernel.org, linux-pwm@vger.kernel.org,
linux-remoteproc@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-usb@vger.kernel.org, linux-serial@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v3 08/11] gpio: sim: Remove gpio_sim_dev_match_fwnode()
Date: Thu, 5 Dec 2024 21:19:02 +0800 [thread overview]
Message-ID: <f150fd45-7f84-4036-aa0e-32bd04fbeb67@icloud.com> (raw)
In-Reply-To: <eyu7nm5hvwfqxgysnrzsvianzf7abvlovpxfo7snsxowmuuhpj@tah3gkqm5ldj>
On 2024/12/5 18:37, Uwe Kleine-König wrote:
> On Thu, Dec 05, 2024 at 04:37:08PM +0800, quic_zijuhu wrote:
>> On 12/5/2024 4:10 PM, Uwe Kleine-König wrote:
>>> On Thu, Dec 05, 2024 at 08:10:17AM +0800, Zijun Hu wrote:
>>>> From: Zijun Hu <quic_zijuhu@quicinc.com>
>>>>
>>>> gpio_sim_dev_match_fwnode() is a simple wrapper of device_match_fwnode()
>>>> Remvoe the unnecessary wrapper.
>
> Just spotted: s/Remvoe/Remove/
>
this typo error is my mistake, will correct it.
>>>> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
>>>> ---
>>>> drivers/gpio/gpio-sim.c | 7 +------
>>>
>>> I think if you move this patch before patch #4 in your series, you only
>>> have to touch this file once.
>>
>> the precondition of this change is patch #4, it will have building error
>> if moving it before #4.
>>
>> actually, we can only do simplifications with benefits brought by #4.
>
> Ah I see. I thought that device_match_fwnode only got the const for the
> 2nd parameter in patch #4.
>
> Best regards
> Uwe
next prev parent reply other threads:[~2024-12-05 13:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 0:10 [PATCH v3 00/11] driver core: Constify API device_find_child() Zijun Hu
2024-12-05 0:10 ` [PATCH v3 01/11] libnvdimm: Simplify nd_namespace_store() implementation Zijun Hu
2024-12-05 23:30 ` Alison Schofield
2024-12-06 0:56 ` Zijun Hu
2024-12-05 0:10 ` [PATCH v3 02/11] slimbus: core: Constify slim_eaddr_equal() Zijun Hu
2024-12-05 0:10 ` [PATCH v3 03/11] bus: fsl-mc: Constify fsl_mc_device_match() Zijun Hu
2024-12-05 0:10 ` [PATCH v3 04/11] driver core: Constify API device_find_child() then adapt for various usages Zijun Hu
2024-12-05 10:41 ` Uwe Kleine-König
2024-12-05 13:16 ` Zijun Hu
2024-12-05 22:39 ` Alison Schofield
2024-12-06 7:21 ` Uwe Kleine-König
2024-12-06 11:08 ` Zijun Hu
2024-12-06 13:52 ` Takashi Sakamoto
2024-12-08 13:18 ` Zijun Hu
2024-12-05 0:10 ` [PATCH v3 05/11] driver core: Simplify API device_find_child_by_name() implementation Zijun Hu
2024-12-05 0:10 ` [PATCH v3 06/11] driver core: Remove match_any() Zijun Hu
2024-12-05 0:10 ` [PATCH v3 07/11] slimbus: core: Simplify of_find_slim_device() implementation Zijun Hu
2024-12-05 0:10 ` [PATCH v3 08/11] gpio: sim: Remove gpio_sim_dev_match_fwnode() Zijun Hu
2024-12-05 8:10 ` Uwe Kleine-König
2024-12-05 8:37 ` quic_zijuhu
2024-12-05 10:37 ` Uwe Kleine-König
2024-12-05 13:19 ` Zijun Hu [this message]
2024-12-05 16:24 ` Bartosz Golaszewski
2024-12-06 1:00 ` Zijun Hu
2024-12-05 0:10 ` [PATCH v3 09/11] driver core: Introduce an device matching API device_match_type() Zijun Hu
2024-12-05 0:10 ` [PATCH v3 10/11] cxl/pmem: Remove match_nvdimm_bridge() Zijun Hu
2024-12-05 22:49 ` Alison Schofield
2024-12-06 1:02 ` Zijun Hu
2024-12-05 0:10 ` [PATCH v3 11/11] usb: typec: class: Remove both cable_match() and partner_match() Zijun Hu
2024-12-05 0:31 ` [PATCH v3 00/11] driver core: Constify API device_find_child() Zijun Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f150fd45-7f84-4036-aa0e-32bd04fbeb67@icloud.com \
--to=zijun_hu@icloud.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=arm-scmi@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=quic_zijuhu@quicinc.com \
--cc=sparclinux@vger.kernel.org \
--cc=thomas@t-8ch.de \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox